[Foundation] Improve NSArray.From[NS]Objects slightly. by rolfbjarne · Pull Request #24569 · dotnet/macios

rolfbjarne · 2026-01-28T00:03:17Z

Enable nullability.
Reuse existing code to create the native array.
Add tests.
Add xml docs.
Update nullability in some of the consumers of these methods whenever it makes sense.
Add a 'nint count' overload to a few methods that takes 'int count', so that we use 'nint' for 'count' everywhere, and deprecated the 'int count' overloads.

Contributes towards #17285.

* Enable nullability. * Reuse existing code to create the native array. * Add tests. * Add xml docs. * Update nullability in some of the consumers of these methods whenever it makes sense. * Add a 'nint count' overload to a few methods that takes 'int count', so that we use 'nint' for 'count' everywhere, and deprecated the 'int count' overloads. Contributes towards #17285.

Copilot

Pull request overview

This PR improves the NSArray.FromNSObjects and FromObjects methods by enabling nullability, adding comprehensive XML documentation, refactoring to reuse existing code, adding nint count overloads, and wrapping the old int count overloads in conditional compilation for removal in XAMCORE 5.0.

Changes:

Enabled nullability for NSArray factory methods and updated parameter/return types to properly indicate nullable elements
Added comprehensive XML documentation for all public NSArray factory methods
Refactored internal implementation to reuse FromIntPtrs and consolidated logic into FromNativeObjectsImpl
Added nint count overloads for consistency across the API surface
Wrapped deprecated int count overloads in #if !XAMCORE_5_0 for future removal
Updated consumers (NSOrderedSet, NSMutableSet, NSDictionary, etc.) to use nullable types
Added comprehensive test coverage for new and existing functionality

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/Foundation/NSArray.cs	Main implementation changes: enabled nullability, added XML docs, refactored to reuse code, added nint count overloads, deprecated int count overloads
src/Foundation/NSOrderedSet.cs	Updated constructor and MakeNSOrderedSet to use nullable parameters
src/Foundation/NSMutableSet.cs	Updated constructors to use nullable parameters
src/Foundation/NSMutableSet_1.cs	Refactored to use FromNonNullNativeObjects instead of manual null checks
src/Foundation/NSDictionary.cs	Updated constructors and helper methods to use nullable parameters
src/Foundation/NSDictionary_2.cs	Updated constructors and methods to use nullable parameters, changed From to FromNativeObjects
src/Foundation/NSMutableDictionary.cs	Updated FromObjectsAndKeys methods to use nullable parameters
src/Foundation/NSMutableDictionary_2.cs	Updated constructors and methods to use nullable parameters
src/AudioUnit/AudioComponent.cs	Updated lambda to handle nullable Dictionary property
tests/monotouch-test/Foundation/NSArray1Test.cs	Added comprehensive tests for new functionality and edge cases
tests/monotouch-test/Foundation/NSOrderedSetTest.cs	Added tests for nullable constructors and methods
tests/monotouch-test/Foundation/NSMutableSetTest.cs	Added tests for nullable constructors
tests/monotouch-test/Foundation/NSMutableOrderedSetTest.cs	Added tests for nullable constructors
tests/cecil-tests/HandleSafety.KnownFailures.cs	Updated method signature reference from FromNativeObjects to FromNativeObjectsImpl
tests/cecil-tests/Documentation.KnownFailures.txt	Removed entries for methods that now have documentation

…ullability-44-nsarray-fromnsobjects

vs-mobiletools-engineering-service2 · 2026-01-28T09:51:55Z

✅ [CI Build #0393474] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 03934743c65ef3d35b99b82d5bc01708bb31fd25 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-28T09:57:45Z

✅ [PR Build #0393474] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 03934743c65ef3d35b99b82d5bc01708bb31fd25 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-28T10:39:21Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 03934743c65ef3d35b99b82d5bc01708bb31fd25 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-28T10:48:23Z

✅ [CI Build #0393474] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 03934743c65ef3d35b99b82d5bc01708bb31fd25 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-28T10:59:09Z

💻 [CI Build #0393474] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 03934743c65ef3d35b99b82d5bc01708bb31fd25 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-28T11:00:39Z

💻 [CI Build #0393474] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 03934743c65ef3d35b99b82d5bc01708bb31fd25 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-28T11:01:31Z

💻 [CI Build #0393474] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 03934743c65ef3d35b99b82d5bc01708bb31fd25 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-28T11:02:30Z

💻 [CI Build #0393474] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 03934743c65ef3d35b99b82d5bc01708bb31fd25 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-28T11:46:10Z

💻 [CI Build #0393474] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 03934743c65ef3d35b99b82d5bc01708bb31fd25 [PR build]

vs-mobiletools-engineering-service2 · 2026-01-29T16:57:25Z

🚀 [CI Build #0393474] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 117 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 9 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. [attempt 4] Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 03934743c65ef3d35b99b82d5bc01708bb31fd25 [PR build]

rolfbjarne requested a review from dalexsoto as a code owner January 28, 2026 00:03

rolfbjarne requested a review from Copilot January 28, 2026 00:03

Copilot started reviewing on behalf of rolfbjarne January 28, 2026 00:03 View session

This comment has been minimized.

Sign in to view

Auto-format source code

528c364

dalexsoto approved these changes Jan 28, 2026

View reviewed changes

Copilot AI reviewed Jan 28, 2026

View reviewed changes

Comment thread src/Foundation/NSArray.cs

Comment thread src/Foundation/NSArray.cs

Comment thread src/Foundation/NSArray.cs

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits January 28, 2026 10:10

Copilot suggestions.

8f066e8

Merge remote-tracking branch 'origin/main' into dev/rolf/foundation-n…

0393474

…ullability-44-nsarray-fromnsobjects

rolfbjarne enabled auto-merge (squash) January 28, 2026 09:11

This comment has been minimized.

Sign in to view

rolfbjarne merged commit 427f5d1 into main Jan 29, 2026
46 checks passed

rolfbjarne added the copilot label Feb 2, 2026

Conversation

rolfbjarne commented Jan 28, 2026

Uh oh!

This comment has been minimized.

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 28, 2026

✅ [CI Build #0393474] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 28, 2026

✅ [PR Build #0393474] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 28, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 28, 2026

✅ [CI Build #0393474] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 28, 2026

💻 [CI Build #0393474] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 28, 2026

💻 [CI Build #0393474] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 28, 2026

💻 [CI Build #0393474] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 28, 2026

💻 [CI Build #0393474] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Jan 28, 2026

💻 [CI Build #0393474] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Jan 29, 2026

🚀 [CI Build #0393474] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants