[MediaAccessibility] Tweak nullability in MACaptionAppearance.#24581
[MediaAccessibility] Tweak nullability in MACaptionAppearance.#24581rolfbjarne merged 1 commit intomainfrom
Conversation
Allow null for a few parameters where we handle null values with a defined (non-throwing) behavior.
There was a problem hiding this comment.
Pull request overview
This PR updates the nullability annotations for two overloads of the DidDisplayCaptions method in MACaptionAppearance to allow null parameters, since the implementation already handles null values with defined (non-throwing) behavior. The PR also adds proper XML documentation for these methods.
Changes:
- Made the
stringsparameter nullable (string[]?andNSAttributedString[]?) for bothDidDisplayCaptionsoverloads - Added XML documentation comments explaining the methods and their parameters
- Removed the methods from
Documentation.KnownFailures.txtsince they now have proper documentation
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/MediaAccessibility/MediaAccessibility.cs | Updated parameter nullability from string[] to string[]? and NSAttributedString[] to NSAttributedString[]?, and added XML documentation comments for both DidDisplayCaptions overloads |
| tests/cecil-tests/Documentation.KnownFailures.txt | Removed two entries for DidDisplayCaptions methods that now have proper documentation |
✅ [CI Build #50ce436] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #50ce436] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #50ce436] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #50ce436] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #50ce436] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #50ce436] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #50ce436] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #50ce436] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #50ce436] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 117 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Allow null for a few parameters where we handle null values with a defined
(non-throwing) behavior.