[Foundation] Improve NSArray.FromStrings a bit. by rolfbjarne · Pull Request #24583 · dotnet/macios

rolfbjarne · 2026-01-29T22:56:17Z

Enable nullability.
Reuse existing code to create the native array.
Add tests.
Add xml docs.
Update nullability in some of the consumers of these methods whenever it makes sense.
Adjust CFArray.Create|FromStrings methods to match NSArray's equivalent methods.

Contributes towards #17285.

* Enable nullability. * Reuse existing code to create the native array. * Add tests. * Add xml docs. * Update nullability in some of the consumers of these methods whenever it makes sense. * Adjust CFArray.Create|FromStrings methods to match NSArray's equivalent methods. Contributes towards #17285.

Copilot

Pull request overview

This PR improves the NSArray.FromStrings methods and related CFArray methods by enabling nullability, adding better XML documentation, improving the implementation to reuse existing code, and adding comprehensive tests.

Changes:

Enabled nullability in NSArray.FromStrings and added a new FromNullableStrings method for nullable array inputs
Refactored NSArray.FromStrings to reuse CFArray.Create, eliminating duplicated marshaling logic
Updated CFArray.Create and FromStrings to accept nullable strings with proper documentation
Updated consumers (NSSet, NSOrderedSet, NSMutableSet) to accept nullable string arrays
Added comprehensive tests for both NSArray and CFArray with null items

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/Foundation/NSArray.cs	Refactored FromStrings to delegate to CFArray.Create, added FromNullableStrings method, improved XML docs, enabled nullability
src/CoreFoundation/CFArray.cs	Enhanced Create method with IReadOnlyList overload, updated FromStrings signature, added XML documentation
tests/monotouch-test/Foundation/ArrayTest.cs	Added tests for FromStrings with null items, IReadOnlyList, and FromNullableStrings
tests/monotouch-test/CoreFoundation/ArrayTest.cs	Added tests for Create and FromStrings with null items and IReadOnlyList
src/bgen/Generator.cs	Updated generator to use FromNullableStrings for nullable string arrays
src/Foundation/NSSet.cs	Updated constructor to accept nullable string arrays
src/Foundation/NSOrderedSet.cs	Updated constructors to accept nullable string arrays
src/Foundation/NSMutableSet.cs	Updated constructor to accept nullable string arrays
src/CoreText/CTFont.cs	Updated GetDefaultCascadeList to use FromNullableStrings
src/CoreServices/FSEvents.cs	Fixed logic to properly check for null before checking Count

…ullability-44-nsarray-fromstrings

…romstrings

…ullability-44-nsarray-fromstrings

vs-mobiletools-engineering-service2 · 2026-02-03T13:11:36Z

✅ [PR Build #e219ead] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: e219eadb89f4059a4a39243459d3c98d7e377614 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T13:24:18Z

✅ [CI Build #e219ead] Build passed (Build packages) ✅

Pipeline on Agent
Hash: e219eadb89f4059a4a39243459d3c98d7e377614 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T13:48:09Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: e219eadb89f4059a4a39243459d3c98d7e377614 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T14:25:14Z

✅ [CI Build #e219ead] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: e219eadb89f4059a4a39243459d3c98d7e377614 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T14:37:58Z

💻 [CI Build #e219ead] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: e219eadb89f4059a4a39243459d3c98d7e377614 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T14:39:13Z

💻 [CI Build #e219ead] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: e219eadb89f4059a4a39243459d3c98d7e377614 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T14:39:58Z

💻 [CI Build #e219ead] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: e219eadb89f4059a4a39243459d3c98d7e377614 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T14:40:45Z

💻 [CI Build #e219ead] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: e219eadb89f4059a4a39243459d3c98d7e377614 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T14:41:04Z

💻 [CI Build #e219ead] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: e219eadb89f4059a4a39243459d3c98d7e377614 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T15:28:37Z

🚀 [CI Build #e219ead] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 117 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 9 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: e219eadb89f4059a4a39243459d3c98d7e377614 [PR build]

rolfbjarne requested a review from Copilot January 29, 2026 22:56

Copilot started reviewing on behalf of rolfbjarne January 29, 2026 22:56 View session

Copilot AI reviewed Jan 29, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits January 30, 2026 17:20

[tests] Update known sizes.

050ead8

Merge remote-tracking branch 'origin/main' into dev/rolf/foundation-n…

2ee33b6

…ullability-44-nsarray-fromstrings

This comment has been minimized.

Sign in to view

[tests] Update expected sizes.

64b7f6f

rolfbjarne marked this pull request as ready for review January 31, 2026 01:06

Merge branch 'main' into dev/rolf/foundation-nullability-44-nsarray-f…

189051e

…romstrings

rolfbjarne enabled auto-merge (squash) January 31, 2026 01:07

dalexsoto approved these changes Feb 2, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into dev/rolf/foundation-n…

4c505f6

…ullability-44-nsarray-fromstrings

This comment has been minimized.

Sign in to view

rolfbjarne added the copilot label Feb 2, 2026

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'origin/main' into dev/rolf/foundation-n…

e219ead

…ullability-44-nsarray-fromstrings

rolfbjarne merged commit a4585b3 into main Feb 3, 2026
47 checks passed

Conversation

rolfbjarne commented Jan 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 3, 2026

✅ [PR Build #e219ead] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 3, 2026

✅ [CI Build #e219ead] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 3, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 3, 2026

✅ [CI Build #e219ead] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 3, 2026

💻 [CI Build #e219ead] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 3, 2026

💻 [CI Build #e219ead] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 3, 2026

💻 [CI Build #e219ead] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 3, 2026

💻 [CI Build #e219ead] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 3, 2026

💻 [CI Build #e219ead] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 3, 2026

🚀 [CI Build #e219ead] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development