Skip to content

[tools] Enable nullability in the registrars. #24589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 6 commits into from
Feb 4, 2026
Merged

[tools] Enable nullability in the registrars. #24589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
00cfda5
[mtouch/dotnet-linker] Enable nullability for the static registrar.
rolfbjarne Jan 28, 2026
ed2c405
Registrar
rolfbjarne Jan 28, 2026
68c4193
wip dynamic registrar
rolfbjarne Jan 28, 2026
59c01d2
wip
rolfbjarne Jan 29, 2026
9444e73
Auto-format source code
Jan 30, 2026
18c16b0
testsupdate
rolfbjarne Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ObjCRuntime/Class.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ internal unsafe static void Initialize (Runtime.InitializationOptions* options)

for (int i = 0; i < map->assembly_count; i++) {
var assembly = map->assemblies [i];
Runtime.Registrar.SetAssemblyRegistered (Marshal.PtrToStringAuto (assembly.name));
Runtime.Registrar.SetAssemblyRegistered (Marshal.PtrToStringAuto (assembly.name)!);
}
}

Expand Down
156 changes: 86 additions & 70 deletions src/ObjCRuntime/DynamicRegistrar.cs
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 7 additions & 1 deletion src/ObjCRuntime/Registrar.core.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
using System.Diagnostics.CodeAnalysis;
using System.Text;

#nullable enable

namespace Registrar {
abstract partial class Registrar {
[return: NotNullIfNotNull (nameof (getterSelector))]
internal static string? CreateSetterSelector (string? getterSelector)
{
if (string.IsNullOrEmpty (getterSelector))
Expand All @@ -16,8 +18,12 @@ abstract partial class Registrar {
return "set" + ((char) first).ToString () + getterSelector.Substring (1) + ":";
}

public static string SanitizeObjectiveCName (string name)
[return: NotNullIfNotNull (nameof (name))]
public static string? SanitizeObjectiveCName (string? name)
{
if (string.IsNullOrEmpty (name))
return name;

StringBuilder? sb = null;

for (int i = 0; i < name.Length; i++) {
Expand Down
Loading
Loading