[UIKit] Enable nullability and clean up UIAppearance. by rolfbjarne · Pull Request #24596 · dotnet/macios

rolfbjarne · 2026-01-30T22:54:02Z

This is file 4 of 30 files with nullability disabled in UIKit.

Enable nullability (#nullable enable).
Remove unused System.Reflection using directive.
Use ArgumentNullException.ThrowIfNull() instead of manual null checks.
Add nullable annotations (UIAppearance?, object?).
Improve XML documentation comments: remove 'To be added.' placeholders, fix whitespace, add missing docs for operators and GetAppearance methods, add 'see cref' references.

Contributes towards #17285.

This is file 4 of 30 files with nullability disabled in UIKit. * Enable nullability (#nullable enable). * Remove unused System.Reflection using directive. * Use ArgumentNullException.ThrowIfNull() instead of manual null checks. * Add nullable annotations (UIAppearance?, object?). * Improve XML documentation comments: remove 'To be added.' placeholders, fix whitespace, add missing docs for operators and GetAppearance methods, add 'see cref' references. Contributes towards #17285.

Copilot

Pull request overview

Enables nullable reference types for UIKit.UIAppearance and updates related documentation/test baselines to reflect the resulting API/docs output changes.

Changes:

Enabled #nullable in src/UIKit/UIAppearance.cs and updated signatures/null-checks accordingly.
Improved XML documentation for UIAppearance members (operators and GetAppearance overloads).
Updated documentation known-failures and iOS size-test expected outputs to match the new build artifacts.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
tests/dotnet/UnitTests/expected/iOS-NativeAOT-size.txt	Updates expected NativeAOT size baselines to match new output.
tests/dotnet/UnitTests/expected/iOS-MonoVM-size.txt	Updates expected MonoVM size baselines to match new output.
tests/dotnet/UnitTests/expected/iOS-MonoVM-interpreter-size.txt	Updates expected MonoVM interpreter size baselines to match new output.
tests/cecil-tests/Documentation.KnownFailures.txt	Removes `UIAppearance` operator doc entries from the known-failures list (now documented).
src/UIKit/UIAppearance.cs	Enables nullability, refines null checks, and improves XML docs for equality operators and `GetAppearance` overloads.

…ility-uiappearance-04

vs-mobiletools-engineering-service2 · 2026-02-02T09:03:49Z

✅ [CI Build #5cbf90c] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 5cbf90c42e4028782130da4a63048c63afd9f352 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-02T09:15:00Z

✅ [PR Build #5cbf90c] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 5cbf90c42e4028782130da4a63048c63afd9f352 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-02T10:00:55Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 5cbf90c42e4028782130da4a63048c63afd9f352 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-02T10:01:16Z

✅ [CI Build #5cbf90c] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 5cbf90c42e4028782130da4a63048c63afd9f352 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-02T10:11:17Z

💻 [CI Build #5cbf90c] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 5cbf90c42e4028782130da4a63048c63afd9f352 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-02T10:14:50Z

💻 [CI Build #5cbf90c] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 5cbf90c42e4028782130da4a63048c63afd9f352 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-02T10:15:18Z

💻 [CI Build #5cbf90c] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 5cbf90c42e4028782130da4a63048c63afd9f352 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-02T10:16:15Z

💻 [CI Build #5cbf90c] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 5cbf90c42e4028782130da4a63048c63afd9f352 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T09:07:35Z

💻 [CI Build #5cbf90c] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 5cbf90c42e4028782130da4a63048c63afd9f352 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-03T09:11:45Z

🚀 [CI Build #5cbf90c] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 117 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 9 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 5cbf90c42e4028782130da4a63048c63afd9f352 [PR build]

rolfbjarne requested a review from dalexsoto as a code owner January 30, 2026 22:54

rolfbjarne requested a review from Copilot January 30, 2026 22:54

Copilot started reviewing on behalf of rolfbjarne January 30, 2026 22:54 View session

Copilot AI reviewed Jan 30, 2026

View reviewed changes

Comment thread src/UIKit/UIAppearance.cs

Comment thread src/UIKit/UIAppearance.cs

Comment thread src/UIKit/UIAppearance.cs

rolfbjarne enabled auto-merge (squash) January 31, 2026 01:05

dalexsoto approved these changes Feb 2, 2026

View reviewed changes

Merge branch 'main' into dev/rolf/uikit-nullability-uiappearance-04

49f65ca

This comment has been minimized.

Sign in to view

rolfbjarne added 2 commits February 2, 2026 09:01

Merge remote-tracking branch 'origin/main' into dev/rolf/uikit-nullab…

14f7fa8

…ility-uiappearance-04

Update sizes.

5cbf90c

This comment has been minimized.

Sign in to view

rolfbjarne added the copilot label Feb 2, 2026

This comment has been minimized.

Sign in to view

rolfbjarne merged commit 34af8c0 into main Feb 3, 2026
46 checks passed

Conversation

rolfbjarne commented Jan 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 2, 2026

✅ [CI Build #5cbf90c] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 2, 2026

✅ [PR Build #5cbf90c] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 2, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 2, 2026

✅ [CI Build #5cbf90c] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 2, 2026

💻 [CI Build #5cbf90c] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 2, 2026

💻 [CI Build #5cbf90c] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 2, 2026

💻 [CI Build #5cbf90c] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 2, 2026

💻 [CI Build #5cbf90c] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 3, 2026

💻 [CI Build #5cbf90c] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 3, 2026

🚀 [CI Build #5cbf90c] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants