[release/11.0.1xx-preview1] [net11.0] Fix building .NET 10 projects. Fixes #24417.#24634
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes building .NET 10 projects by removing a temporary workaround that was skipping .NET 10 runtime workload dependencies. This is a backport of #24633 to the release/11.0.1xx-preview1 branch.
Changes:
- Removed special case logic that was skipping .NET 10 workload dependencies in the workload manifest generator
- The workaround is no longer needed as the
microsoft-net-runtime-*-net10workloads now exist
✅ [CI Build #de20978] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #de20978] Build passed (Detect API changes) ✅Pipeline on Agent |
jonathanpeppers
left a comment
There was a problem hiding this comment.
Is there a test that is missing? (or needs enabled?)
Android has a few tests that build/run net10.0-android projects in main.
✅ [CI Build #de20978] Build passed (Build macOS tests) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
💻 [CI Build #de20978] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #de20978] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
We have .NET 10 tests that work just fine. Also I wasn't able to reproduce the problem in a plain iOS app, only in a MAUI app. I don't know why, but I believe it's MAUI for some reason that brings in a dependency that we fix by doing this? |
💻 [CI Build #de20978] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #de20978] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 117 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
Fixes #24417.
Backport of #24633.