Skip to content

[release/11.0.1xx-preview1] [net11.0] Fix building .NET 10 projects. Fixes #24417.#24634

Merged
rolfbjarne merged 1 commit intorelease/11.0.1xx-preview1from
dev/rolf/backport-pr-24633-release/11.0.1xx-preview1-2026-02-05
Feb 5, 2026
Merged

[release/11.0.1xx-preview1] [net11.0] Fix building .NET 10 projects. Fixes #24417.#24634
rolfbjarne merged 1 commit intorelease/11.0.1xx-preview1from
dev/rolf/backport-pr-24633-release/11.0.1xx-preview1-2026-02-05

Conversation

@rolfbjarne
Copy link
Copy Markdown
Member

Fixes #24417.

Backport of #24633.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes building .NET 10 projects by removing a temporary workaround that was skipping .NET 10 runtime workload dependencies. This is a backport of #24633 to the release/11.0.1xx-preview1 branch.

Changes:

  • Removed special case logic that was skipping .NET 10 workload dependencies in the workload manifest generator
  • The workaround is no longer needed as the microsoft-net-runtime-*-net10 workloads now exist

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [CI Build #de20978] Build passed (Build packages) ✅

Pipeline on Agent
Hash: de209789aed8fe9bfe4c9201e5f5232b9d113e5b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [PR Build #de20978] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: de209789aed8fe9bfe4c9201e5f5232b9d113e5b [PR build]

Copy link
Copy Markdown
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test that is missing? (or needs enabled?)

Android has a few tests that build/run net10.0-android projects in main.

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [CI Build #de20978] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: de209789aed8fe9bfe4c9201e5f5232b9d113e5b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: de209789aed8fe9bfe4c9201e5f5232b9d113e5b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

💻 [CI Build #de20978] Tests on macOS X64 - Mac Sonoma (14) passed 💻

All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: de209789aed8fe9bfe4c9201e5f5232b9d113e5b [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

💻 [CI Build #de20978] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: de209789aed8fe9bfe4c9201e5f5232b9d113e5b [PR build]

@rolfbjarne
Copy link
Copy Markdown
Member Author

Is there a test that is missing? (or needs enabled?)

Android has a few tests that build/run net10.0-android projects in main.

We have .NET 10 tests that work just fine.

Also I wasn't able to reproduce the problem in a plain iOS app, only in a MAUI app.

I don't know why, but I believe it's MAUI for some reason that brings in a dependency that we fix by doing this?

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

💻 [CI Build #de20978] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: de209789aed8fe9bfe4c9201e5f5232b9d113e5b [PR build]

@rolfbjarne rolfbjarne enabled auto-merge (squash) February 5, 2026 18:58
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

🚀 [CI Build #de20978] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 117 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 4 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (iOS): All 9 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 9 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 9 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: de209789aed8fe9bfe4c9201e5f5232b9d113e5b [PR build]

@rolfbjarne rolfbjarne merged commit 7a768c3 into release/11.0.1xx-preview1 Feb 5, 2026
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants