[build] Remove the sharpie dependency.#24719
Conversation
We no longer need it, we have our own sharpie.
There was a problem hiding this comment.
Pull request overview
Removes the legacy external ObjectiveSharpie (“sharpie”) provisioning/dependency from the repo’s devops provisioning scripts and configuration, aligning the build/provisioning flow with the repo’s in-tree sharpie tooling.
Changes:
- Removed Sharpie provisioning from the devops provisioning csx scripts and related Makefile substitution.
- Removed Sharpie install/version checks and CLI flags from
system-dependencies.sh. - Updated pipeline provisioning invocation and removed developer docs pointing to
--provision-sharpie.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/devops/provision-shared.in.csx | Removes ProvisionSharpie() provisioning item. |
| tools/devops/build-provisioning.csx | Stops calling ProvisionSharpie(). |
| tools/devops/automation/templates/windows/reserve-mac.yml | Drops --ignore-sharpie from simulator provisioning step. |
| tools/devops/Makefile | Removes MIN_SHARPIE_URL token substitution for provisioning script generation. |
| tests/xtro-sharpie/README.md | Removes instructions to provision ObjectiveSharpie via system-dependencies.sh. |
| system-dependencies.sh | Removes Sharpie-related flags and ObjectiveSharpie install/version checks. |
| Make.config | Removes ObjectiveSharpie min/max version and URL configuration entries. |
✅ [CI Build #330aa0e] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #330aa0e] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #330aa0e] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #330aa0e] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #330aa0e] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #330aa0e] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #330aa0e] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #330aa0e] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
🚀 [CI Build #330aa0e] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 131 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
We no longer need it, we have our own sharpie.