[build] Remove the code to create msbuild.zip/bundle.zip.#24724
[build] Remove the code to create msbuild.zip/bundle.zip.#24724rolfbjarne merged 1 commit intomainfrom
Conversation
We don't use the msbuild.zip/bundle.zip files anymore, so the code to produce these can be deleted.
There was a problem hiding this comment.
Pull request overview
This PR removes obsolete build infrastructure for producing msbuild.zip and bundle.zip artifacts. These files were previously uploaded to wrench and packaged into the VS plugin, but are no longer used by the current build system. The modern build system uses build-nugets.sh to produce packages which are placed in the ../package/ directory.
Changes:
- Deleted the entire
release/Makefilecontaining obsolete targets for buildingmsbuild.zipandbundle.zip - Deleted
release/.gitignorewhich only contained entries for obsolete release artifacts - Removed the
packageandreleasemake targets from the mainMakefilethat invoked the now-deleted release build
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| release/Makefile | Deleted entire file containing obsolete msbuild.zip and bundle.zip build targets |
| release/.gitignore | Deleted entire file containing gitignore patterns for obsolete release artifacts |
| Makefile | Removed obsolete package/release make targets that invoked release/Makefile |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #fd97209] Build passed (Build packages) ✅Pipeline on Agent |
✅ [CI Build #fd97209] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #fd97209] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #fd97209] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #fd97209] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #fd97209] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #fd97209] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [PR Build #fd97209] Build passed (Detect API changes) ✅Pipeline on Agent |
🚀 [CI Build #fd97209] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 131 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
We don't use the msbuild.zip/bundle.zip files anymore, so the code to produce
these can be deleted.