[ObjCRuntime] Enable nullability and clean up Blocks. by rolfbjarne · Pull Request #24726 · dotnet/macios

rolfbjarne · 2026-02-17T18:14:12Z

This is file 1 of 7 files with nullability disabled in ObjCRuntime.

Enable nullability (#nullable enable).
Add nullable annotations for block delegate conversion paths and related helper signatures.
Fix number of places where the block API was consumed.
Improve BlockLiteral XML documentation (ordering, spacing, cref usage, and missing member docs).
Fix grammar in docs/api/ObjCRuntime/BlockLiteral.xml.

Contributes towards #17285.

This is file 1 of 7 files with nullability disabled in ObjCRuntime. * Enable nullability (#nullable enable). * Add nullable annotations for block delegate conversion paths and related helper signatures. * Fix number of places where the block API was consumed. * Improve BlockLiteral XML documentation (ordering, spacing, cref usage, and missing member docs). * Fix grammar in docs/api/ObjCRuntime/BlockLiteral.xml. Contributes towards #17285.

Copilot

Pull request overview

This pull request enables nullable reference types in src/ObjCRuntime/Blocks.cs and updates all consumers of the BlockLiteral API to handle nullable delegates correctly. This is part 1 of a 7-file effort to enable nullability in the ObjCRuntime namespace.

Changes:

Enabled #nullable enable in Blocks.cs and added nullable annotations throughout
Updated BlockLiteral.GetTarget<T>() to return T? and added null-safety checks at all call sites
Enhanced XML documentation with better formatting, <see> references, and an updated code example
Added helper methods GetTypeName() and GetMethodName() for null-safe error message formatting
Updated the code generator (bgen) to emit null checks for non-void block trampolines

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/ObjCRuntime/Blocks.cs	Enabled nullability, updated API signatures to use nullable types, improved documentation, added helper methods for error messages
src/bgen/Generator.cs	Updated trampoline generator to add null checks for non-void return types
src/UIKit/UIGuidedAccessRestriction.cs	Replaced direct block access with `BlockLiteral.GetTarget()` helper
src/UIKit/UIConfigurationColorTransformer.cs	Replaced direct block access with `BlockLiteral.GetTarget()` helper
src/UIKit/UICellAccessory.cs	Replaced direct block access with `BlockLiteral.GetTarget()` helper, added null check
src/UIKit/UIAccessibility.cs	Replaced direct block access with `BlockLiteral.GetTarget()` helper
src/Security/SecSharedCredential.cs	Replaced direct block access with `BlockLiteral.GetTarget()` helper (2 locations)
src/MetalPerformanceShaders/MPSImageBatch.cs	Replaced direct block access with `BlockLiteral.GetTarget()` helper, removed redundant cast
src/Metal/MTLDevice.cs	Replaced direct block access with `BlockLiteral.GetTarget()` helper
src/ImageIO/CGImageMetadata.cs	Added null check for delegate retrieved via `BlockLiteral.GetTarget()`
docs/api/ObjCRuntime/BlockLiteral.xml	Removed external XML documentation (now inline in source)
tests/cecil-tests/Documentation.KnownFailures.txt	Removed `BlockLiteral.Dispose` from known failures (now documented)

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

vs-mobiletools-engineering-service2 · 2026-02-18T09:05:12Z

✅ [CI Build #9a32ce1] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 9a32ce1a5d33b60a953cd1a4960bb3293d6d9dc0 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-18T09:07:58Z

✅ [PR Build #9a32ce1] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 9a32ce1a5d33b60a953cd1a4960bb3293d6d9dc0 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-18T09:46:06Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 9a32ce1a5d33b60a953cd1a4960bb3293d6d9dc0 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-18T10:07:34Z

✅ [CI Build #9a32ce1] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 9a32ce1a5d33b60a953cd1a4960bb3293d6d9dc0 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-18T10:17:31Z

💻 [CI Build #9a32ce1] Tests on macOS X64 - Mac Sonoma (14) passed 💻

✅ All tests on macOS X64 - Mac Sonoma (14) passed.

Pipeline on Agent
Hash: 9a32ce1a5d33b60a953cd1a4960bb3293d6d9dc0 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-18T10:20:27Z

💻 [CI Build #9a32ce1] Tests on macOS M1 - Mac Monterey (12) passed 💻

✅ All tests on macOS M1 - Mac Monterey (12) passed.

Pipeline on Agent
Hash: 9a32ce1a5d33b60a953cd1a4960bb3293d6d9dc0 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-18T10:21:26Z

💻 [CI Build #9a32ce1] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

✅ All tests on macOS arm64 - Mac Sequoia (15) passed.

Pipeline on Agent
Hash: 9a32ce1a5d33b60a953cd1a4960bb3293d6d9dc0 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-18T10:21:50Z

💻 [CI Build #9a32ce1] Tests on macOS M1 - Mac Ventura (13) passed 💻

✅ All tests on macOS M1 - Mac Ventura (13) passed.

Pipeline on Agent
Hash: 9a32ce1a5d33b60a953cd1a4960bb3293d6d9dc0 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-18T10:21:53Z

💻 [CI Build #9a32ce1] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

✅ All tests on macOS arm64 - Mac Tahoe (26) passed.

Pipeline on Agent
Hash: 9a32ce1a5d33b60a953cd1a4960bb3293d6d9dc0 [PR build]

vs-mobiletools-engineering-service2 · 2026-02-18T15:22:18Z

🚀 [CI Build #9a32ce1] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 131 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 9a32ce1a5d33b60a953cd1a4960bb3293d6d9dc0 [PR build]

rolfbjarne requested a review from dalexsoto as a code owner February 17, 2026 18:14

rolfbjarne requested a review from Copilot February 17, 2026 18:14

rolfbjarne added the copilot label Feb 17, 2026

Copilot started reviewing on behalf of rolfbjarne February 17, 2026 18:14 View session

Copilot AI reviewed Feb 17, 2026

View reviewed changes

Comment thread src/ObjCRuntime/Blocks.cs Outdated

Comment thread src/ObjCRuntime/Blocks.cs Outdated

Auto-format source code

4d3bfcd

This comment has been minimized.

Sign in to view

Update src/ObjCRuntime/Blocks.cs

9a32ce1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

rolfbjarne enabled auto-merge (squash) February 18, 2026 08:25

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Feb 18, 2026

View reviewed changes

rolfbjarne merged commit 5849bb5 into main Feb 18, 2026
48 checks passed

Conversation

rolfbjarne commented Feb 17, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 18, 2026

✅ [CI Build #9a32ce1] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 18, 2026

✅ [PR Build #9a32ce1] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 18, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 18, 2026

✅ [CI Build #9a32ce1] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 18, 2026

💻 [CI Build #9a32ce1] Tests on macOS X64 - Mac Sonoma (14) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 18, 2026

💻 [CI Build #9a32ce1] Tests on macOS M1 - Mac Monterey (12) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 18, 2026

💻 [CI Build #9a32ce1] Tests on macOS arm64 - Mac Sequoia (15) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 18, 2026

💻 [CI Build #9a32ce1] Tests on macOS M1 - Mac Ventura (13) passed 💻

Uh oh!

vs-mobiletools-engineering-service2 commented Feb 18, 2026

💻 [CI Build #9a32ce1] Tests on macOS arm64 - Mac Tahoe (26) passed 💻

Uh oh!

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Feb 18, 2026

🚀 [CI Build #9a32ce1] Test results 🚀

Test results

Tests counts

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants