[ObjCRuntime] Enable nullability and clean up TypeConverter.#24733
[ObjCRuntime] Enable nullability and clean up TypeConverter.#24733rolfbjarne merged 1 commit intomainfrom
Conversation
This is file 2 of 7 files with nullability disabled in ObjCRuntime. * Enable nullability (#nullable enable). * Add nullability-aware argument validation and element-type checks using ThrowHelper for static analysis. * Improve XML documentation comments: fix formatting/order, grammar, and add relevant see cref references. Contributes towards #17285. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Enables nullable reference types for ObjCRuntime.TypeConverter and tightens its public API contract by adding null/empty validation, while also modernizing the XML documentation for the type conversion APIs.
Changes:
- Enabled
#nullable enableinTypeConverter.cs. - Added argument validation (null + empty string checks) and nullability-aware element-type handling.
- Updated XML docs for clarity, grammar, and link formatting.
✅ [CI Build #8a92c64] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #8a92c64] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #8a92c64] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #8a92c64] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #8a92c64] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #8a92c64] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #8a92c64] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #8a92c64] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #8a92c64] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 131 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
This is file 2 of 7 files with nullability disabled in ObjCRuntime.
Contributes towards #17285.