Skip to content

[ObjCRuntime] Enable nullability and clean up BackingField.#24734

Merged
rolfbjarne merged 3 commits intomainfrom
dev/rolf/objcruntime-nullability-backingfield-04
Feb 19, 2026
Merged

[ObjCRuntime] Enable nullability and clean up BackingField.#24734
rolfbjarne merged 3 commits intomainfrom
dev/rolf/objcruntime-nullability-backingfield-04

Conversation

@rolfbjarne
Copy link
Copy Markdown
Member

This is file 4 of 7 files with nullability disabled in ObjCRuntime.

  • Enable nullability (#nullable enable).
  • Add nullable annotations for cached backing-field helper APIs.
  • Add converter null checks using ThrowHelper to improve static analysis.
  • Add XML documentation for BackingField and its public helper methods.

Contributes towards #17285.

This is file 4 of 7 files with nullability disabled in ObjCRuntime.

* Enable nullability (#nullable enable).
* Add nullable annotations for cached backing-field helper APIs.
* Add converter null checks using ThrowHelper to improve static analysis.
* Add XML documentation for BackingField and its public helper methods.

Contributes towards #17285.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables nullable reference types in ObjCRuntime’s BackingField helper to improve static analysis and better document the backing-field caching pattern used by bindings.

Changes:

  • Enabled #nullable enable for BackingField.cs.
  • Updated BackingField.Get/Save signatures to use nullable backing fields (T?) and added null-check for the converter.
  • Added XML documentation for BackingField and its public helper methods.

Comment thread src/ObjCRuntime/BackingField.cs Outdated
Comment thread src/ObjCRuntime/BackingField.cs Outdated
@rolfbjarne rolfbjarne enabled auto-merge (squash) February 18, 2026 15:28
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [CI Build #9c3ebe1] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 9c3ebe1d5f4b5f8794ce7292997945c56cca866e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [PR Build #9c3ebe1] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 9c3ebe1d5f4b5f8794ce7292997945c56cca866e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 9c3ebe1d5f4b5f8794ce7292997945c56cca866e [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [CI Build #9c3ebe1] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 9c3ebe1d5f4b5f8794ce7292997945c56cca866e [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

🚀 [CI Build #9c3ebe1] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 156 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Pipeline on Agent
Hash: 9c3ebe1d5f4b5f8794ce7292997945c56cca866e [PR build]

@rolfbjarne rolfbjarne merged commit 6ec2798 into main Feb 19, 2026
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants