[ObjCRuntime] Enable nullability and clean up CategoryAttribute.#24744
Conversation
This is file 6 of 7 files with nullability disabled in ObjCRuntime. * Enable nullability (#nullable enable). * Add nullability-aware API updates for category name metadata. * Inline XML documentation from CategoryAttribute.xml into source and remove the include file. * Improve XML documentation formatting, grammar, and cref usage. Contributes towards #17285. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Enables nullable reference types for ObjCRuntime.CategoryAttribute, updates the attribute API to be nullability-aware for category name metadata, and moves XML documentation inline (removing the standalone XML include file) as part of the ongoing ObjCRuntime nullability work toward #17285.
Changes:
- Enabled
#nullable enableinCategoryAttributeand madeNamenullable (string?) to reflect “optional category name” semantics. - Inlined and reformatted XML documentation from
CategoryAttribute.xmlinto the source file. - Removed
docs/api/ObjCRuntime/CategoryAttribute.xml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/ObjCRuntime/CategoryAttribute.cs | Enables nullability, updates Name to string?, and inlines/reformats XML docs. |
| docs/api/ObjCRuntime/CategoryAttribute.xml | Removed since docs are now inlined in the source. |
✅ [CI Build #c38787c] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #c38787c] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #c38787c] Build passed (Build macOS tests) ✅Pipeline on Agent |
🚀 [CI Build #c38787c] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 156 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
This is file 6 of 7 files with nullability disabled in ObjCRuntime.
Contributes towards #17285.