[devops] Skip macOS test results when neither macOS nor Mac Catalyst is enabled.#24793
[devops] Skip macOS test results when neither macOS nor Mac Catalyst is enabled.#24793rolfbjarne merged 6 commits intomainfrom
Conversation
When macOS/MacCatalyst platforms are disabled, the macOS test stages are skipped (RUN_MAC_TESTS=false). Previously, the test result aggregation would still include these entries and report them as failures since no results were found. Now, when a mac test has no corresponding stage dependency results (indicating the stage was skipped), it is excluded from the comment entirely instead of being reported as a failure.
There was a problem hiding this comment.
Pull request overview
Updates the Azure DevOps test-matrix generation so macOS-specific test configurations are excluded when neither macOS nor MacCatalyst is enabled, preventing irrelevant mac test jobs/results from being produced in non-mac platform runs.
Changes:
- Add filtering in
Get-TestConfigurationto skip configs markedisMacTestunlessmacOSorMacCatalystis enabled. - Add Pester tests validating mac tests are excluded when mac platforms are disabled (and included when
macOSis enabled). - Update
Make.configdefaults to not enableINCLUDE_MAC/INCLUDE_MACCATALYST.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tools/devops/automation/scripts/TestConfiguration.psm1 | Adds mac-test filtering based on enabled platforms during matrix creation. |
| tools/devops/automation/scripts/TestConfiguration.Tests.ps1 | Adds regression tests for the new mac-test filtering behavior. |
| Make.config | Disables macOS/Mac Catalyst by default via empty INCLUDE_MAC* values. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Use 'dependencies' instead of 'stageDependencies' in the stage-level condition in mac/stage.yml. At the stage level, Azure DevOps requires 'dependencies' to access dependent stage outputs (matching the pattern already used in windows/stage.yml). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
🔥 [CI Build #95c853e] Test results 🔥Test results❌ Tests failed on VSTS: test results 1 tests crashed, 13 tests failed, 138 tests passed. Failures❌ linker tests11 tests failed, 33 tests passed.Failed tests
|
✅ [CI Build #6b67dfb] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #6b67dfb] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #6b67dfb] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #6b67dfb] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 156 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
No description provided.