[release/10.0.1xx] Include .mobile.props for DTB (fix for VS Code)#24804
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the shared Apple .NET SDK MSBuild props to import per-project .mobile.props during design-time builds, ensuring VS Code design-time builds pick the correct iOS device RuntimeIdentifier so Roslyn resolves the proper baseline assemblies for Hot Reload.
Changes:
- Import
$(MSBuildProjectName).mobile.propswhenDesignTimeBuild=truein addition toBuildingInsideVisualStudio=true. - Update the accompanying comment to reflect the broader trigger (VS + VS Code design-time builds).
✅ [CI Build #af053e3] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #af053e3] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #af053e3] Build passed (Build macOS tests) ✅Pipeline on Agent |
💻 [CI Build #af053e3] Tests on macOS X64 - Mac Sonoma (14) passed 💻✅ All tests on macOS X64 - Mac Sonoma (14) passed. Pipeline on Agent |
💻 [CI Build #af053e3] Tests on macOS M1 - Mac Monterey (12) passed 💻✅ All tests on macOS M1 - Mac Monterey (12) passed. Pipeline on Agent |
💻 [CI Build #af053e3] Tests on macOS arm64 - Mac Sequoia (15) passed 💻✅ All tests on macOS arm64 - Mac Sequoia (15) passed. Pipeline on Agent |
💻 [CI Build #af053e3] Tests on macOS M1 - Mac Ventura (13) passed 💻✅ All tests on macOS M1 - Mac Ventura (13) passed. Pipeline on Agent |
💻 [CI Build #af053e3] Tests on macOS arm64 - Mac Tahoe (26) passed 💻✅ All tests on macOS arm64 - Mac Tahoe (26) passed. Pipeline on Agent |
🚀 [CI Build #af053e3] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 117 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
This PR makes a change to improve the Hot Reload experience for .NET MAUI iOS device builds in VS Code:
In VS Code, design-time builds did not receive the correct RuntimeIdentifier for iOS device targets — they defaulted to iossimulator-x64. This caused Roslyn to resolve the wrong baseline assemblies, that broke Hot Reload. The .mobile.props mechanism (already used by VS on Windows) solves this.
As discussed with Mauro and Tomas, the better solution is not to introduce a new parameter, but add "DesignTimeBuild" as one of the triggers for the condition. This is safe for both VS and VS Code and should not cause any side effects.
Co-authored-by: Kirill Ovchinnikov kovchinnikov@microsoft.com
Backport of #24801.