[sharpie] Set a few required properties for the nupkg.#24813
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Sharpie .NET tool NuGet package metadata so the produced nupkg includes standard repository and branding information (repo URL/commit/branch, icon, authors/owners).
Changes:
- Add NuGet package metadata properties (repo info, authors/owners/copyright, icon, project URL) to
Sharpie.Bind.Tool.csproj. - Include
Icon.pngin the packed output soPackageIconis valid. - Pass
CurrentBranch/CurrentHashintodotnet packfrom the Sharpie make target; also emit branch/hash values into generatedBuild.props.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tools/sharpie/Sharpie.Bind.Tool/Sharpie.Bind.Tool.csproj | Adds package metadata (repo info, authors/owners, icon/project URL) and packs the icon file. |
| tools/sharpie/Makefile | Passes branch/hash MSBuild properties to dotnet pack so repository metadata can be populated. |
| Make.config | Writes branch/hash values into generated Build.props for MSBuild consumption. |
Comments suppressed due to low confidence (1)
Make.config:368
- Make.config now writes MSBuild properties named
CURRENT_BRANCHandCURRENT_HASH_LONGinto Build.props, but the repo’s packing projects (including Sharpie.Bind.Tool.csproj in this PR, and dotnet/package/common.csproj) use$(CurrentBranch)/$(CurrentHash)(different property names, not just casing). As-is, these new Build.props values won't flow into the nupkg metadata unless callers also pass/p:CurrentBranchand/p:CurrentHash, and the new properties appear unused by MSBuild.
Consider either (1) emitting <CurrentBranch> and <CurrentHash> in Build.props to match the established convention, or (2) removing these Build.props entries and relying solely on the explicit /p: values passed to dotnet pack for Sharpie.
$(Q) printf "\t\t<CURRENT_BRANCH>$(CURRENT_BRANCH)</CURRENT_BRANCH>\n" >> $@.tmp
$(Q) printf "\t\t<CURRENT_HASH_LONG>$(CURRENT_HASH_LONG)</CURRENT_HASH_LONG>\n" >> $@.tmp
✅ [CI Build #de4674c] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #de4674c] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ [CI Build #de4674c] Build passed (Build macOS tests) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
🚀 [CI Build #de4674c] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 156 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
No description provided.