[sharpie] Add the sharpie nupkg version to 'make show-versions'.#24827
[sharpie] Add the sharpie nupkg version to 'make show-versions'.#24827rolfbjarne merged 1 commit intomainfrom
Conversation
This required a few simplifications to the 'create-makefile-fragment.sh' script to avoid trying to create a makefile fragment if we don't have .NET downloaded yet, because 'make show-versions' should succeed without a downloaded .NET.
There was a problem hiding this comment.
Pull request overview
This PR adds the Sharpie nupkg version to the output of make show-versions, ensuring it appears alongside the .NET NuGet version info when checking the build system. To make this work without a downloaded .NET (since make show-versions should succeed even on a fresh checkout), the create-makefile-fragment.sh script was simplified: it now exits silently if the dotnet executable doesn't yet exist on disk, rather than failing.
Changes:
make show-versionsnow also invokesmake -C tools/sharpie show-versionto display theSharpie.Bind.ToolNuGet version.create-makefile-fragment.shwas simplified to always hardcodeBUILD_EXECUTABLE="$DOTNET build"and exit silently (exit 0) when the dotnet executable file is absent.- The now-redundant
export BUILD_EXECUTABLE=$(DOTNET) buildline was removed fromtools/dotnet-linker/Makefile.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tools/sharpie/Makefile |
Adds the show-version phony-style target that echoes SHARPIE_BIND_TOOL_NUGET_VERSION. |
Makefile |
Calls $(MAKE) -C tools/sharpie show-version as part of the show-versions target. |
tools/common/create-makefile-fragment.sh |
Removes the BUILD_EXECUTABLE override mechanism; adds a graceful early-exit if the dotnet binary doesn't exist yet. |
tools/dotnet-linker/Makefile |
Drops the now-unnecessary export BUILD_EXECUTABLE=$(DOTNET) build line. |
You can also share your feedback on Copilot code review. Take the survey.
✅ [CI Build #cbb7e1a] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #cbb7e1a] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #cbb7e1a] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #cbb7e1a] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 156 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Pipeline on Agent |
This required a few simplifications to the 'create-makefile-fragment.sh'
script to avoid trying to create a makefile fragment if we don't have .NET
downloaded yet, because 'make show-versions' should succeed without a
downloaded .NET.