Skip to content

[msbuild] Revamp finding a simulator to use when running an app in the simulator. Fixes #25112. #25129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 12 commits into from
Apr 14, 2026
Merged

[msbuild] Revamp finding a simulator to use when running an app in the simulator. Fixes #25112. #25129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
1592fc1
Default to latest available simulator runtime
rolfbjarne Apr 9, 2026
4cf27a4
Refactor simulator device selection
rolfbjarne Apr 9, 2026
1032524
Use GetAvailableDevices for simulator choice
rolfbjarne Apr 9, 2026
37430a9
Error when no launch devices exist
rolfbjarne Apr 9, 2026
c47f2f7
wip
rolfbjarne Apr 9, 2026
2b54ec4
Report discarded launch devices
rolfbjarne Apr 9, 2026
66c78ae
Filter launch device item groups
rolfbjarne Apr 9, 2026
eca00c3
Update msbuild/Xamarin.MacDev.Tasks/Tasks/GetMlaunchArguments.cs
rolfbjarne Apr 13, 2026
4bc688c
Update tests/msbuild/Xamarin.MacDev.Tasks.Tests/TaskTests/GetMlaunchA…
rolfbjarne Apr 13, 2026
796aae3
Merge remote-tracking branch 'origin/main' into dev/rolf/msbuild-exac…
rolfbjarne Apr 13, 2026
14521eb
Fix build error.
rolfbjarne Apr 13, 2026
81eebbf
Fix discarded device help output
rolfbjarne Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions dotnet/targets/Microsoft.Sdk.Mobile.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,14 @@

<Target
Name="ShowRunHelp"
DependsOnTargets="_DetectSdkLocations;_GenerateBundleName;_DetectAppManifest">
DependsOnTargets="_DetectSdkLocations;_GenerateBundleName;_DetectAppManifest;ComputeAvailableDevices">
<Error Condition="$([MSBuild]::IsOSPlatform('windows'))" Text="It's currently not supported to launch an app from the command line on Windows." />
<Error Condition="!Exists('$(_AppBundleManifestPath)')" Text="The app must be built before showing how to launch it." />

<GetMlaunchArguments
AppManifestPath="$(_AppBundleManifestPath)"
DiscardedDevices="@(DiscardedDevices)"
Devices="@(Devices)"
Help="true"
MlaunchPath="$(MlaunchPath)"
SdkDevPath="$(_SdkDevPath)"
Expand All @@ -44,7 +46,7 @@
</Target>
<Target Name="_ShowRunHelpConditioned" Condition="'$(Help)' == 'true'" DependsOnTargets="ShowRunHelp" />

<Target Name="ComputeMlaunchInstallArguments" DependsOnTargets="_DetectSdkLocations;_GenerateBundleName;_DetectAppManifest;_ShowRunHelpConditioned;_ComputeMlaunchInstallArguments" />
<Target Name="ComputeMlaunchInstallArguments" DependsOnTargets="_DetectSdkLocations;_GenerateBundleName;_DetectAppManifest;ComputeAvailableDevices;_ShowRunHelpConditioned;_ComputeMlaunchInstallArguments" />
<Target Name="_ComputeMlaunchInstallArguments" Condition="'$(_SdkIsSimulator)' == 'false' And '$(Help)' != 'true'">
<!-- Launching from the command line on windows hasn't been implemented: https://github.com/dotnet/macios/issues/16609 -->
<Error Condition="$([MSBuild]::IsOSPlatform('windows'))" Text="It's currently not supported to launch an app from the command line on Windows." />
Expand All @@ -53,6 +55,8 @@
<GetMlaunchArguments
SessionId="$(BuildSessionId)"
AppManifestPath="$(_AppBundleManifestPath)"
DiscardedDevices="@(DiscardedDevices)"
Devices="@(Devices)"
DeviceName="$(Device)"
InstallApp="$(_AppBundlePath)"
MlaunchPath="$(MlaunchPath)"
Expand All @@ -77,7 +81,7 @@
<Exec SessionId="$(BuildSessionId)" Command="'$(MlaunchPath)' $(MlaunchInstallArguments)" />
</Target>

<Target Name="ComputeMlaunchRunArguments" DependsOnTargets="_DetectSdkLocations;_GenerateBundleName;_DetectAppManifest;_ShowRunHelpConditioned;_ComputeMlaunchRunArguments" Condition="'$(_PlatformName)' != 'macOS' And '$(_PlatformName)' != 'MacCatalyst'" />
<Target Name="ComputeMlaunchRunArguments" DependsOnTargets="_DetectSdkLocations;_GenerateBundleName;_DetectAppManifest;ComputeAvailableDevices;_ShowRunHelpConditioned;_ComputeMlaunchRunArguments" Condition="'$(_PlatformName)' != 'macOS' And '$(_PlatformName)' != 'MacCatalyst'" />

<Target Name="_ComputeMlaunchRunArguments" Condition="'$(Help)' != 'true'">
<!-- Launching from the command line on windows hasn't been implemented: https://github.com/dotnet/macios/issues/16609 -->
Expand Down Expand Up @@ -105,6 +109,8 @@
AdditionalArguments="@(MlaunchAdditionalArguments)"
AppManifestPath="$(_AppBundleManifestPath)"
CaptureOutput="$(_MlaunchCaptureOutput)"
DiscardedDevices="@(DiscardedDevices)"
Devices="@(Devices)"
DeviceName="$(Device)"
EnvironmentVariables="@(MlaunchEnvironmentVariables)"
LaunchApp="$(_AppBundlePath)"
Expand Down
Loading
Loading