[Foundation] Enable HTTP digest auth in NSUrlSessionHandler by rolfbjarne · Pull Request #25180 · dotnet/macios

rolfbjarne · 2026-04-17T15:44:27Z

NSUrlSessionHandler was explicitly rejecting HTTP digest challenges by mapping NSURLAuthenticationMethodHTTPDigest to the internal reject sentinel. That meant iOS never answered digest auth challenges with configured credentials, while other supported auth schemes did.

Handle digest challenges like other credential-backed auth methods so Credentials.GetCredential can return a NetworkCredential and the handler can respond with an NSUrlCredential.

Add a System.Net.Http regression test covering successful and failed digest authentication, and add a shared httpbin helper for the digest auth endpoint.

Recreated from #25179 (by @mandel-macaque) to not use a fork.

NSUrlSessionHandler was explicitly rejecting HTTP digest challenges by mapping NSURLAuthenticationMethodHTTPDigest to the internal reject sentinel. That meant iOS never answered digest auth challenges with configured credentials, while other supported auth schemes did. Handle digest challenges like other credential-backed auth methods so Credentials.GetCredential can return a NetworkCredential and the handler can respond with an NSUrlCredential. Add a System.Net.Http regression test covering successful and failed digest authentication, and add a shared httpbin helper for the digest auth endpoint. Local monotouch-test build validation was attempted, but this checkout is currently blocked by the expected Xcode installation and local build environment configuration.

Copilot

Pull request overview

Enables HTTP Digest authentication in NSUrlSessionHandler by treating digest challenges as credential-backed auth (instead of explicitly rejecting them), and adds a regression test to validate digest auth behavior against httpbin.

Changes:

Map NSURLAuthenticationMethodHTTPDigest to a non-reject auth type so Credentials.GetCredential can supply credentials.
Add an httpbin URL helper for the digest auth endpoint.
Add a System.Net.Http test covering successful and failed digest authentication scenarios.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File	Description
`src/Foundation/NSUrlSessionHandler.cs`	Stops rejecting digest challenges; allows credential lookup/response for digest auth.
`tests/monotouch-test/System.Net.Http/NetworkResources.cs`	Adds httpbin digest-auth endpoint URL helper used by tests.
`tests/monotouch-test/System.Net.Http/MessageHandlers.cs`	Adds regression test verifying digest auth works (success + failure cases).

rolfbjarne · 2026-04-20T11:36:37Z

@mandel-macaque there are some test failures:

MonoTests.System.Net.Http.MessageHandlerTest.SupportsDigestAuthentication : 2314.5388 ms
	[PASS] TestNSUrlSessionDefaultDisableCookiesWithManagedContainer
	[PASS] TestNSUrlSessionDefaultDisabledCookies
	[PASS] TestNSUrlSessionEphemeralDisabledCookies
	[FAIL] TestNSUrlSessionEphemeralHandlerCookieContainer :   Cookies
       Expected string length 54 but was 165. Strings differ at index 47.
       Expected: "...    "cookie": "chocolate-chip"\n  }\n}\n"
       But was:  "...    "cookie": "chocolate-chip", \n    "fake": "fake_value",..."
  --------------------------------------------^
		   at MonoTests.System.Net.Http.MessageHandlerTest.TestNSUrlSessionHandlerCookieContainerImpl(NSUrlSessionHandler nativeHandler) in /Users/builder/azdo/_work/1/s/macios/tests/monotouch-test/System.Net.Http/MessageHandlers.cs:line 177
		   at MonoTests.System.Net.Http.MessageHandlerTest.TestNSUrlSessionEphemeralHandlerCookieContainer() in /Users/builder/azdo/_work/1/s/macios/tests/monotouch-test/System.Net.Http/MessageHandlers.cs:line 133
	[FAIL] TestNSUrlSessionEphemeralHandlerCookies :   Managed Cookie Count
       Expected: 1
       But was:  4
		   at MonoTests.System.Net.Http.MessageHandlerTest.TestNSUrlSessionHandlerCookiesImpl(NSUrlSessionHandler nativeHandler) in /Users/builder/azdo/_work/1/s/macios/tests/monotouch-test/System.Net.Http/MessageHandlers.cs:line 116
		   at MonoTests.System.Net.Http.MessageHandlerTest.TestNSUrlSessionEphemeralHandlerCookies() in /Users/builder/azdo/_work/1/s/macios/tests/monotouch-test/System.Net.Http/MessageHandlers.cs:line 83
	[FAIL] TestNSUrlSessionHandlerCookieContainer :   Cookies
       Expected string length 54 but was 165. Strings differ at index 47.
       Expected: "...    "cookie": "chocolate-chip"\n  }\n}\n"
       But was:  "...    "cookie": "chocolate-chip", \n    "fake": "fake_value",..."
  --------------------------------------------^
		   at MonoTests.System.Net.Http.MessageHandlerTest.TestNSUrlSessionHandlerCookieContainerImpl(NSUrlSessionHandler nativeHandler) in /Users/builder/azdo/_work/1/s/macios/tests/monotouch-test/System.Net.Http/MessageHandlers.cs:line 177
		   at MonoTests.System.Net.Http.MessageHandlerTest.TestNSUrlSessionHandlerCookieContainer() in /Users/builder/azdo/_work/1/s/macios/tests/monotouch-test/System.Net.Http/MessageHandlers.cs:line 126
	[IGNORED] TestNSurlSessionHandlerCookieContainerSetCookie : Unexpected network failure in CI
Ignoring test, because not running in CI: Unexpected network failure in CI
		   at TestRuntime.IgnoreInCI(String message) in /Users/builder/azdo/_work/1/s/macios/tests/common/TestRuntime.cs:line 196
		   at MonoTests.System.Net.Http.MessageHandlerTest.TestNSurlSessionHandlerCookieContainerSetCookie() in /Users/builder/azdo/_work/1/s/macios/tests/monotouch-test/System.Net.Http/MessageHandlers.cs:line 206
	[FAIL] TestNSUrlSessionHandlerCookies :   Managed Cookie Count
       Expected: 1
       But was:  4
		   at MonoTests.System.Net.Http.MessageHandlerTest.TestNSUrlSessionHandlerCookiesImpl(NSUrlSessionHandler nativeHandler) in /Users/builder/azdo/_work/1/s/macios/tests/monotouch-test/System.Net.Http/MessageHandlers.cs:line 116
		   at MonoTests.System.Net.Http.MessageHandlerTest.TestNSUrlSessionHandlerCookies() in /Users/builder/azdo/_work/1/s/macios/tests/monotouch-test/System.Net.Http/MessageHandlers.cs:line 75
	[PASS] TestNSUrlSessionHandlerDetectMissingClientCertificate
	[PASS] TestNSUrlSessionHandlerDetectMissingClientCertificateOptOut
	[PASS] TestNSUrlSessionHandlerOptionalClientCertificate
	[PASS] TestNSUrlSessionHandlerSendClientCertificate
	[PASS] TestNSUrlSessionTimeoutExceptionWhileStreamingContent

vs-mobiletools-engineering-service2 · 2026-04-21T06:40:53Z

✅ [CI Build #463be1c] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 463be1ca767f4725ab0a12279d32de82a9bab4f1 [PR build]

vs-mobiletools-engineering-service2 · 2026-04-21T06:43:59Z

✅ [PR Build #463be1c] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 463be1ca767f4725ab0a12279d32de82a9bab4f1 [PR build]

vs-mobiletools-engineering-service2 · 2026-04-21T06:55:50Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 463be1ca767f4725ab0a12279d32de82a9bab4f1 [PR build]

vs-mobiletools-engineering-service2 · 2026-04-21T07:07:24Z

✅ [CI Build #463be1c] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 463be1ca767f4725ab0a12279d32de82a9bab4f1 [PR build]

vs-mobiletools-engineering-service2 · 2026-04-21T11:08:25Z

🚀 [CI Build #463be1c] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 156 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. [attempt 2] Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: 463be1ca767f4725ab0a12279d32de82a9bab4f1 [PR build]

dalexsoto

lgtm

rolfbjarne added the community Community contribution ❤ label Apr 17, 2026

rolfbjarne self-assigned this Apr 17, 2026

rolfbjarne requested a review from Copilot April 17, 2026 15:45

rolfbjarne mentioned this pull request Apr 17, 2026

[Foundation] Enable HTTP digest auth in NSUrlSessionHandler #25179

Closed

Copilot started reviewing on behalf of rolfbjarne April 17, 2026 15:45 View session

Copilot AI reviewed Apr 17, 2026

View reviewed changes

Comment thread tests/monotouch-test/System.Net.Http/MessageHandlers.cs

Comment thread tests/monotouch-test/System.Net.Http/MessageHandlers.cs

Comment thread tests/monotouch-test/System.Net.Http/NetworkResources.cs

Comment thread tests/monotouch-test/System.Net.Http/MessageHandlers.cs

This comment has been minimized.

Sign in to view

Make tests not be as picky with the assertions. (#25194)

7c6c7e2

This comment has been minimized.

Sign in to view

Merge branch 'main' into dev/manuel/add-digest-auth-nsurlhandler

463be1c

This comment has been minimized.

Sign in to view

dalexsoto approved these changes Apr 22, 2026

View reviewed changes

rolfbjarne merged commit 727a5e4 into main Apr 22, 2026
48 checks passed

This was referenced Apr 22, 2026

[CI Postmortem] 'macOS tests' build stage failing across multiple PRs #25215

Closed

[CI Postmortem] Linker test build failures (trimmode copy, link all) across PRs #25216

Closed

Conversation

rolfbjarne commented Apr 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

rolfbjarne commented Apr 20, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Apr 21, 2026

✅ [CI Build #463be1c] Build passed (Build packages) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Apr 21, 2026

✅ [PR Build #463be1c] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 21, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Apr 21, 2026

✅ [CI Build #463be1c] Build passed (Build macOS tests) ✅

Uh oh!

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Apr 21, 2026

🚀 [CI Build #463be1c] Test results 🚀

Test results

Tests counts

macOS tests

Linux Build Verification

Uh oh!

dalexsoto left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

rolfbjarne commented Apr 17, 2026 •

edited

Loading