Skip to content

Add eng/Signing.props to sign cab files inside MSI workload packs#25192

Merged
rolfbjarne merged 1 commit intomainfrom
release-test/rt/sign-cab-files
Apr 22, 2026
Merged

Add eng/Signing.props to sign cab files inside MSI workload packs#25192
rolfbjarne merged 1 commit intomainfrom
release-test/rt/sign-cab-files

Conversation

@rolfbjarne
Copy link
Copy Markdown
Member

The VS signing scan flags 42 unsigned cab1.cab files inside macOS SDK and Templates workload pack MSI payloads. The Arcade SDK's default Sign.props does not include a FileExtensionSignInfo for .cab, so the SignTool skips signing them even though .cab is in SignableExtensions.

Add eng/Signing.props with:

  • FileExtensionSignInfo for .cab -> Microsoft400
  • UseDotNetCertificate = true (standard for dotnet/* repos)
  • ItemsToSign entries for *.msi and *.wixpack.zip so the SignTool opens MSI containers and signs embedded cabs

This is recreating #25184 from origin since we can't build from forks.

The VS signing scan flags 42 unsigned cab1.cab files inside macOS SDK
and Templates workload pack MSI payloads. The Arcade SDK's default
Sign.props does not include a FileExtensionSignInfo for .cab, so the
SignTool skips signing them even though .cab is in SignableExtensions.

Add eng/Signing.props with:
- FileExtensionSignInfo for .cab -> Microsoft400
- UseDotNetCertificate = true (standard for dotnet/* repos)
- ItemsToSign entries for *.msi and *.wixpack.zip so the SignTool
  opens MSI containers and signs embedded cabs
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [CI Build #11d6661] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 11d666131148be5b6c4315ff220c982c659c1c74 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [CI Build #11d6661] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 11d666131148be5b6c4315ff220c982c659c1c74 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 11d666131148be5b6c4315ff220c982c659c1c74 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [CI Build #11d6661] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: 11d666131148be5b6c4315ff220c982c659c1c74 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [CI Build #11d6661] Prepare .NET Release succeeded ✅

📦 Published NuGet packages (32 packages)

iOS

  • Microsoft.iOS.Ref.net10.0_26.4.26.4.10213-rt.nupkg
  • Microsoft.iOS.Runtime.ios-arm64.net10.0_26.4.26.4.10213-rt.nupkg
  • Microsoft.iOS.Runtime.ios.net10.0_26.4.26.4.10213-rt.nupkg
  • Microsoft.iOS.Runtime.iossimulator-arm64.net10.0_26.4.26.4.10213-rt.nupkg
  • Microsoft.iOS.Runtime.iossimulator-x64.net10.0_26.4.26.4.10213-rt.nupkg
  • Microsoft.iOS.Sdk.net10.0_26.4.26.4.10213-rt.nupkg
  • Microsoft.iOS.Templates.26.4.10213-rt.nupkg
  • Microsoft.iOS.Windows.Sdk.net10.0_26.4.26.4.10213-rt.nupkg
  • Microsoft.NET.Sdk.iOS.Manifest-10.0.300-preview.0.26.4.10213-rt.nupkg

MacCatalyst

  • Microsoft.MacCatalyst.Ref.net10.0_26.4.26.4.10213-rt.nupkg
  • Microsoft.MacCatalyst.Runtime.maccatalyst-arm64.net10.0_26.4.26.4.10213-rt.nupkg
  • Microsoft.MacCatalyst.Runtime.maccatalyst-x64.net10.0_26.4.26.4.10213-rt.nupkg
  • Microsoft.MacCatalyst.Runtime.maccatalyst.net10.0_26.4.26.4.10213-rt.nupkg
  • Microsoft.MacCatalyst.Sdk.net10.0_26.4.26.4.10213-rt.nupkg
  • Microsoft.MacCatalyst.Templates.26.4.10213-rt.nupkg
  • Microsoft.NET.Sdk.MacCatalyst.Manifest-10.0.300-preview.0.26.4.10213-rt.nupkg

macOS

  • Microsoft.macOS.Ref.net10.0_26.4.26.4.10213-rt.nupkg
  • Microsoft.macOS.Runtime.osx-arm64.net10.0_26.4.26.4.10213-rt.nupkg
  • Microsoft.macOS.Runtime.osx-x64.net10.0_26.4.26.4.10213-rt.nupkg
  • Microsoft.macOS.Runtime.osx.net10.0_26.4.26.4.10213-rt.nupkg
  • Microsoft.macOS.Sdk.net10.0_26.4.26.4.10213-rt.nupkg
  • Microsoft.macOS.Templates.26.4.10213-rt.nupkg
  • Microsoft.NET.Sdk.macOS.Manifest-10.0.300-preview.0.26.4.10213-rt.nupkg

tvOS

  • Microsoft.NET.Sdk.tvOS.Manifest-10.0.300-preview.0.26.4.10213-rt.nupkg
  • Microsoft.tvOS.Ref.net10.0_26.4.26.4.10213-rt.nupkg
  • Microsoft.tvOS.Runtime.tvos-arm64.net10.0_26.4.26.4.10213-rt.nupkg
  • Microsoft.tvOS.Runtime.tvos.net10.0_26.4.26.4.10213-rt.nupkg
  • Microsoft.tvOS.Runtime.tvossimulator-arm64.net10.0_26.4.26.4.10213-rt.nupkg
  • Microsoft.tvOS.Runtime.tvossimulator-x64.net10.0_26.4.26.4.10213-rt.nupkg
  • Microsoft.tvOS.Sdk.net10.0_26.4.26.4.10213-rt.nupkg
  • Microsoft.tvOS.Templates.26.4.10213-rt.nupkg

Other

  • Sharpie.Bind.Tool.26.4.0.213-rt.nupkg

Pipeline on Agent
Hash: 11d666131148be5b6c4315ff220c982c659c1c74 [PR build]

@rolfbjarne
Copy link
Copy Markdown
Member Author

Publishing worked fine, so this looks good to go: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=13882703&view=results

@rolfbjarne rolfbjarne enabled auto-merge (squash) April 20, 2026 15:07
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

🚀 [CI Build #11d6661] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 156 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. [attempt 3] Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

Linux build succeeded

Pipeline on Agent
Hash: 11d666131148be5b6c4315ff220c982c659c1c74 [PR build]

Copy link
Copy Markdown
Member

@dalexsoto dalexsoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@rolfbjarne rolfbjarne merged commit 7e68a96 into main Apr 22, 2026
59 checks passed
@rolfbjarne rolfbjarne deleted the release-test/rt/sign-cab-files branch April 22, 2026 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants