Add eng/Signing.props to sign cab files inside MSI workload packs#25192
Add eng/Signing.props to sign cab files inside MSI workload packs#25192rolfbjarne merged 1 commit intomainfrom
Conversation
The VS signing scan flags 42 unsigned cab1.cab files inside macOS SDK and Templates workload pack MSI payloads. The Arcade SDK's default Sign.props does not include a FileExtensionSignInfo for .cab, so the SignTool skips signing them even though .cab is in SignableExtensions. Add eng/Signing.props with: - FileExtensionSignInfo for .cab -> Microsoft400 - UseDotNetCertificate = true (standard for dotnet/* repos) - ItemsToSign entries for *.msi and *.wixpack.zip so the SignTool opens MSI containers and signs embedded cabs
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #11d6661] Build passed (Build packages) ✅Pipeline on Agent |
✅ [CI Build #11d6661] Build passed (Detect API changes) ✅Pipeline on Agent |
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
✅ [CI Build #11d6661] Build passed (Build macOS tests) ✅Pipeline on Agent |
✅ [CI Build #11d6661] Prepare .NET Release succeeded ✅📦 Published NuGet packages (32 packages)iOS
MacCatalyst
macOS
tvOS
Other
Pipeline on Agent |
|
Publishing worked fine, so this looks good to go: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=13882703&view=results |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #11d6661] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 156 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |
The VS signing scan flags 42 unsigned cab1.cab files inside macOS SDK and Templates workload pack MSI payloads. The Arcade SDK's default Sign.props does not include a FileExtensionSignInfo for .cab, so the SignTool skips signing them even though .cab is in SignableExtensions.
Add eng/Signing.props with:
This is recreating #25184 from origin since we can't build from forks.