[tests] Simplify MonoTouch.Dialog.#25203
Conversation
rolfbjarne
commented
Apr 21, 2026
- Remove code we don't use.
- Enable nullability and fix any issues.
* Remove code we don't use. * Enable nullability and fix any issues.
There was a problem hiding this comment.
Pull request overview
This PR trims down the tests/common/MonoTouch.Dialog test dependency by removing unused components and enabling C# nullable reference types, updating the remaining code to compile cleanly under nullable analysis.
Changes:
- Enable nullable reference types and treat nullable warnings as errors for
MonoTouch.Dialog. - Remove unused elements/utilities (cache, graphics helpers, custom controls, and several legacy elements).
- Update remaining APIs/implementations with nullable annotations and null-safe logic (events, properties, UI plumbing).
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/common/MonoTouch.Dialog/shared.csproj | Enables nullable and makes nullable diagnostics fatal for this test library. |
| tests/common/MonoTouch.Dialog/Utilities/Controls.cs | Removes unused types; updates FromResource to return UIImage? and adds null-handling. |
| tests/common/MonoTouch.Dialog/Elements.cs | Removes unused element types and updates remaining elements for nullable correctness. |
| tests/common/MonoTouch.Dialog/DialogViewController.cs | Updates search/filter and table source logic for nullable correctness; removes unused search-related APIs. |
| tests/common/MonoTouch.Dialog/Utilities/LRUCache.cs | Deleted (unused). |
| tests/common/MonoTouch.Dialog/Utilities/Graphics.cs | Deleted (unused). |
| tests/common/MonoTouch.Dialog/Utilities/GlassButton.cs | Deleted (unused). |
| tests/common/MonoTouch.Dialog/OldElements/LoadMoreElement.cs | Deleted (unused). |
| tests/common/MonoTouch.Dialog/Elements/OwnerDrawnElement.cs | Deleted (unused). |
| tests/common/MonoTouch.Dialog/Elements/MessageElement.cs | Deleted (unused). |
| tests/common/MonoTouch.Dialog/Elements/ActivityElement.cs | Deleted (unused). |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
✅ [CI Build #e7ada32] Build passed (Build packages) ✅Pipeline on Agent |
✅ [PR Build #e7ada32] Build passed (Detect API changes) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ API diff for current PR / commitNET (empty diffs)✅ API diff vs stableNET (empty diffs)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
✅ [CI Build #e7ada32] Build passed (Build macOS tests) ✅Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build #e7ada32] Test results 🚀Test results✅ All tests passed on VSTS: test results. 🎉 All 156 tests passed 🎉 Tests counts✅ cecil: All 1 tests passed. Html Report (VSDrops) Download macOS tests✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download Linux Build VerificationPipeline on Agent |