Skip to content

[tests] Simplify MonoTouch.Dialog.#25203

Merged
rolfbjarne merged 3 commits intomainfrom
dev/rolf/tests-nullability-monotouch-dialog
Apr 23, 2026
Merged

[tests] Simplify MonoTouch.Dialog.#25203
rolfbjarne merged 3 commits intomainfrom
dev/rolf/tests-nullability-monotouch-dialog

Conversation

@rolfbjarne
Copy link
Copy Markdown
Member

  • Remove code we don't use.
  • Enable nullability and fix any issues.

* Remove code we don't use.
* Enable nullability and fix any issues.
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR trims down the tests/common/MonoTouch.Dialog test dependency by removing unused components and enabling C# nullable reference types, updating the remaining code to compile cleanly under nullable analysis.

Changes:

  • Enable nullable reference types and treat nullable warnings as errors for MonoTouch.Dialog.
  • Remove unused elements/utilities (cache, graphics helpers, custom controls, and several legacy elements).
  • Update remaining APIs/implementations with nullable annotations and null-safe logic (events, properties, UI plumbing).

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/common/MonoTouch.Dialog/shared.csproj Enables nullable and makes nullable diagnostics fatal for this test library.
tests/common/MonoTouch.Dialog/Utilities/Controls.cs Removes unused types; updates FromResource to return UIImage? and adds null-handling.
tests/common/MonoTouch.Dialog/Elements.cs Removes unused element types and updates remaining elements for nullable correctness.
tests/common/MonoTouch.Dialog/DialogViewController.cs Updates search/filter and table source logic for nullable correctness; removes unused search-related APIs.
tests/common/MonoTouch.Dialog/Utilities/LRUCache.cs Deleted (unused).
tests/common/MonoTouch.Dialog/Utilities/Graphics.cs Deleted (unused).
tests/common/MonoTouch.Dialog/Utilities/GlassButton.cs Deleted (unused).
tests/common/MonoTouch.Dialog/OldElements/LoadMoreElement.cs Deleted (unused).
tests/common/MonoTouch.Dialog/Elements/OwnerDrawnElement.cs Deleted (unused).
tests/common/MonoTouch.Dialog/Elements/MessageElement.cs Deleted (unused).
tests/common/MonoTouch.Dialog/Elements/ActivityElement.cs Deleted (unused).

Comment thread tests/common/MonoTouch.Dialog/DialogViewController.cs
Comment thread tests/common/MonoTouch.Dialog/DialogViewController.cs
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne rolfbjarne marked this pull request as ready for review April 22, 2026 14:44
@rolfbjarne rolfbjarne enabled auto-merge (squash) April 22, 2026 14:44
@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [CI Build #e7ada32] Build passed (Build packages) ✅

Pipeline on Agent
Hash: e7ada3205f5d6c3fbc372c221c7e16d65171a260 [PR build]

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [PR Build #e7ada32] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: e7ada3205f5d6c3fbc372c221c7e16d65171a260 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ API diff for current PR / commit

NET (empty diffs)

✅ API diff vs stable

NET (empty diffs)

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: e7ada3205f5d6c3fbc372c221c7e16d65171a260 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

✅ [CI Build #e7ada32] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: e7ada3205f5d6c3fbc372c221c7e16d65171a260 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@vs-mobiletools-engineering-service2
Copy link
Copy Markdown
Collaborator

🚀 [CI Build #e7ada32] Test results 🚀

Test results

✅ All tests passed on VSTS: test results.

🎉 All 156 tests passed 🎉

Tests counts

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ interdependent-binding-projects: All 4 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ linker: All 44 tests passed. Html Report (VSDrops) Download
✅ monotouch (iOS): All 11 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xcframework: All 4 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

Linux build succeeded

Pipeline on Agent
Hash: e7ada3205f5d6c3fbc372c221c7e16d65171a260 [PR build]

@vs-mobiletools-engineering-service2

This comment has been minimized.

@rolfbjarne rolfbjarne merged commit 8be4923 into main Apr 23, 2026
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants