[tests] Enable nullability in Touch.Unit. by rolfbjarne · Pull Request #25204 · dotnet/macios

rolfbjarne · 2026-04-21T09:38:27Z

No description provided.

- Add null check for CGContext from UIGraphics.GetCurrentContext() - Use var with null-coalescing for UIGraphics.GetImageFromCurrentImageContext() Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

vs-mobiletools-engineering-service2 · 2026-04-24T15:40:19Z

✅ [PR Build #ef6399e] Build passed (Build packages) ✅

Pipeline on Agent
Hash: ef6399e0a75f493162da660d3faba8d0038f5a37 [PR build]

vs-mobiletools-engineering-service2 · 2026-04-24T15:44:04Z

✅ [PR Build #ef6399e] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: ef6399e0a75f493162da660d3faba8d0038f5a37 [PR build]

vs-mobiletools-engineering-service2 · 2026-04-24T15:57:23Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: ef6399e0a75f493162da660d3faba8d0038f5a37 [PR build]

vs-mobiletools-engineering-service2 · 2026-04-24T16:07:12Z

✅ [CI Build #ef6399e] Build passed (Build macOS tests) ✅

Pipeline on Agent
Hash: ef6399e0a75f493162da660d3faba8d0038f5a37 [PR build]

vs-mobiletools-engineering-service2 · 2026-04-24T18:38:45Z

🔥 [CI Build #ef6399e] Test results 🔥

Test results

❌ Tests failed on VSTS: test results

0 tests crashed, 37 tests failed, 119 tests passed.

Failures

❌ interdependent-binding-projects tests

2 tests failed, 2 tests passed.

Failed tests

interdependent-binding-projects/iOS - simulator/Debug: LaunchTimedOut
interdependent-binding-projects/tvOS - simulator/Debug: LaunchTimedOut

Html Report (VSDrops) Download

❌ linker tests

22 tests failed, 22 tests passed.

Failed tests

dont link/iOS - simulator/Debug: LaunchTimedOut
dont link/iOS - simulator/Release: LaunchTimedOut
dont link/tvOS - simulator/Debug: LaunchTimedOut
dont link/tvOS - simulator/Release: LaunchTimedOut
link sdk/iOS - simulator/Debug: LaunchTimedOut
link sdk/iOS - simulator/Release: LaunchTimedOut
link sdk/tvOS - simulator/Debug: LaunchTimedOut
link sdk/tvOS - simulator/Release: LaunchTimedOut
link all/iOS - simulator/Debug: LaunchTimedOut
link all/iOS - simulator/Release: LaunchTimedOut
link all/iOS - simulator/Debug (don't bundle original resources): LaunchTimedOut
link all/tvOS - simulator/Debug: LaunchTimedOut
link all/tvOS - simulator/Release: LaunchTimedOut
link all/tvOS - simulator/Debug (don't bundle original resources): LaunchTimedOut
trimmode copy/iOS - simulator/Debug: LaunchTimedOut
trimmode copy/iOS - simulator/Release: LaunchTimedOut
trimmode copy/tvOS - simulator/Debug: LaunchTimedOut
trimmode copy/tvOS - simulator/Release: LaunchTimedOut
trimmode link/iOS - simulator/Debug: LaunchTimedOut
trimmode link/iOS - simulator/Release: LaunchTimedOut
trimmode link/tvOS - simulator/Debug: LaunchTimedOut
trimmode link/tvOS - simulator/Release: LaunchTimedOut

Html Report (VSDrops) Download

❌ monotouch tests (iOS)

11 tests failed, 0 tests passed.

Failed tests

monotouch-test/iOS - simulator/Debug: LaunchTimedOut
monotouch-test/iOS - simulator/Debug (LinkSdk): LaunchTimedOut
monotouch-test/iOS - simulator/Debug (static registrar): LaunchTimedOut
monotouch-test/iOS - simulator/Release (all optimizations): LaunchTimedOut
monotouch-test/iOS - simulator/Debug (ARM64): LaunchTimedOut
monotouch-test/iOS - simulator/Release (NativeAOT, ARM64): LaunchTimedOut
monotouch-test/iOS - simulator/Debug (managed static registrar): LaunchTimedOut
monotouch-test/iOS - simulator/Release (managed static registrar, all optimizations): LaunchTimedOut
monotouch-test/iOS - simulator/Release (NativeAOT, x64): LaunchTimedOut
monotouch-test/iOS - simulator/Debug (interpreter): LaunchTimedOut
monotouch-test/iOS - simulator/Release (interpreter): LaunchTimedOut

Html Report (VSDrops) Download

❌ xcframework tests

2 tests failed, 2 tests passed.

Failed tests

xcframework-test/iOS - simulator/Debug: LaunchTimedOut
xcframework-test/tvOS - simulator/Debug: LaunchTimedOut

Html Report (VSDrops) Download

Successes

✅ cecil: All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (iOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (MacCatalyst): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (macOS): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (Multiple platforms): All 1 tests passed. Html Report (VSDrops) Download
✅ dotnettests (tvOS): All 1 tests passed. Html Report (VSDrops) Download
✅ framework: All 2 tests passed. Html Report (VSDrops) Download
✅ fsharp: All 4 tests passed. Html Report (VSDrops) Download
✅ generator: All 5 tests passed. Html Report (VSDrops) Download
✅ introspection: All 6 tests passed. Html Report (VSDrops) Download
✅ monotouch (MacCatalyst): All 15 tests passed. Html Report (VSDrops) Download
✅ monotouch (macOS): All 12 tests passed. Html Report (VSDrops) Download
✅ monotouch (tvOS): All 11 tests passed. Html Report (VSDrops) Download
✅ msbuild: All 2 tests passed. Html Report (VSDrops) Download
✅ sharpie: All 1 tests passed. Html Report (VSDrops) Download
✅ windows: All 3 tests passed. Html Report (VSDrops) Download
✅ xtro: All 1 tests passed. Html Report (VSDrops) Download

macOS tests

✅ Tests on macOS Monterey (12): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Ventura (13): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sonoma (14): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Sequoia (15): All 5 tests passed. Html Report (VSDrops) Download
✅ Tests on macOS Tahoe (26): All 5 tests passed. Html Report (VSDrops) Download

Linux Build Verification

✅ Linux build succeeded

Pipeline on Agent
Hash: ef6399e0a75f493162da660d3faba8d0038f5a37 [PR build]

rolfbjarne · 2026-04-28T07:47:10Z

All test results are green, the last build just failed to post the comment saying so.

rolfbjarne and others added 2 commits April 21, 2026 11:36

[tests] Enable nullability in Touch.Unit.

6262887

Auto-format source code

0624231

This comment has been minimized.

Sign in to view

This was referenced Apr 22, 2026

[CI Postmortem] dotnettests (tvos/maccatalyst/macos/ios) failing across multiple PRs #25214

Closed

[CI Postmortem] Dotnet tests stage execution failures across multiple PRs #25218

Closed

rolfbjarne marked this pull request as ready for review April 22, 2026 14:45

rolfbjarne enabled auto-merge (squash) April 22, 2026 14:45

This comment has been minimized.

Sign in to view

Missing fix

38da80f

This comment has been minimized.

Sign in to view

Fix nullability errors in TouchViewController.GetAwesomeIcon

ea4ddff

- Add null check for CGContext from UIGraphics.GetCurrentContext() - Use var with null-coalescing for UIGraphics.GetImageFromCurrentImageContext() Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

This comment has been minimized.

Sign in to view

Merge branch 'main' into dev/rolf/tests-nullability-touch-client

ef6399e

rolfbjarne disabled auto-merge April 28, 2026 07:47

rolfbjarne merged commit 6850539 into main Apr 28, 2026
10 checks passed

rolfbjarne added the copilot label Apr 28, 2026

Conversation

rolfbjarne commented Apr 21, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Apr 24, 2026

✅ [PR Build #ef6399e] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 24, 2026

✅ [PR Build #ef6399e] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 24, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 24, 2026

✅ [CI Build #ef6399e] Build passed (Build macOS tests) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Apr 24, 2026

🔥 [CI Build #ef6399e] Test results 🔥

Test results

Failures

❌ interdependent-binding-projects tests

Failed tests

❌ linker tests

Failed tests

❌ monotouch tests (iOS)

Failed tests

❌ xcframework tests

Failed tests

Successes

macOS tests

Linux Build Verification

Uh oh!

rolfbjarne commented Apr 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone