[msbuild] Add a condition to make sure empty item groups aren't processed.#25236
Merged
[msbuild] Add a condition to make sure empty item groups aren't processed.#25236
Conversation
…ssed. This is a workaround for dotnet/msbuild#4056. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2903015.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an MSBuild item-group guard to avoid processing an empty item list, working around dotnet/msbuild#4056 in the Xamarin.Shared post-processing item collection logic.
Changes:
- Add a
Conditionto only create_PostProcessingItementries for frameworks when_FilteredFrameworkToPublishis non-empty. - Document the reason for the condition with a reference to the upstream MSBuild issue.
mauroa
approved these changes
Apr 23, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dalexsoto
approved these changes
Apr 23, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dalexsoto
pushed a commit
that referenced
this pull request
Apr 24, 2026
…groups aren't processed. (#25237) This is a workaround for dotnet/msbuild#4056. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2903015. Backport of #25236.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a workaround for dotnet/msbuild#4056.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2903015.