Skip to content

Fix flaky UrlProtocolTest.RegistrarTest race condition. Fixes #25223 #25255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 2 commits into from
Apr 30, 2026
Merged

Fix flaky UrlProtocolTest.RegistrarTest race condition. Fixes #25223 #25255

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfa90f0
Fix flaky UrlProtocolTest.RegistrarTest race condition
rolfbjarne Apr 27, 2026
859b6c4
Merge remote-tracking branch 'origin/main' into dev/rolf/fix-urlproto…
rolfbjarne Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/monotouch-test/Foundation/UrlProtocolTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ public void Task ()
[Test]
public void RegistrarTest ()
{
CustomUrlProtocol.State = 0;
var success = false;

var task = Task.Run (async () => {
Expand All @@ -76,7 +77,10 @@ public void RegistrarTest ()
}
});

Assert.IsTrue (TestRuntime.RunAsync (TimeSpan.FromSeconds (10), task), "Timed out");
// Use the completion check overload so RunAsync also waits for
// StopLoading to fire (State reaches 5) instead of returning as
// soon as the download task completes (State may still be 4).
Assert.IsTrue (TestRuntime.RunAsync (TimeSpan.FromSeconds (10), task, () => CustomUrlProtocol.State >= 5), "Timed out");
Assert.That (CustomUrlProtocol.State, Is.EqualTo (5), "State");
Assert.IsTrue (success, "Success");
}
Expand Down
Loading