[XHarness] Add the Mono.Data.Tds tests. #2900
Conversation
|
Since mono-2017-07 is not going to land I create this on 2017-10 with the same changes as PR #2800 that will be closed. |
| </ItemGroup> | ||
| <Import Project="$(MSBuildExtensionsPath)\Xamarin\Mac\Xamarin.Mac.CSharp.targets" /> | ||
| <ItemGroup> | ||
| <EmbeddedResource Include="..\..\..\external\mono\mcs\class\corlib\Test\resources\Resources.es-ES.resx"> |
There was a problem hiding this comment.
Are these corlib resources really required for the Mono.Data.Tds tests?
There was a problem hiding this comment.
Good catch. For tds we do not need them.
tests/xharness/Harness.cs
Outdated
| "System.ServiceModel.Web", | ||
| "Mono.Data.Sqlite", | ||
| "Mono.Data.Tds", | ||
| "Mono.Data.Tds", |
There was a problem hiding this comment.
You have "Mono.Data.Tds" twice.
mandel-macaque
force-pushed
the
mono-data-tds-tests-2017-10
branch
from
115d4dc to
0ee1361
Compare
|
Build failure |
| <Reference Include="Xamarin.Mac" /> | ||
| <Reference Include="GuiUnit"> | ||
| <HintPath>..\..\..\external\guiunit\src\framework\obj\Debug\net-4.5\GuiUnit.exe</HintPath> | ||
| <HintPath>..\..\..\external\guiunit\src\framework\obj\Debug\xammac_mobile\GuiUnit.exe</HintPath> |
There was a problem hiding this comment.
Why is this xammac_mobile?
$ cat ./System/System-mac.csproj.template | grep GuiUnit
<Reference Include="GuiUnit">
<HintPath>..\..\..\external\guiunit\src\framework\obj\Debug\net-4.5\GuiUnit.exe</HintPath>
cat ./System.Xml/System.Xml-mac.csproj.template | grep GuiUnit
<Reference Include="GuiUnit">
<HintPath>..\..\..\external\guiunit\src\framework\obj\Debug\net-4.5\GuiUnit.exe</HintPath>
There was a problem hiding this comment.
Maybe this should be a project reference instead, that should solve the problem.
| <Reference Include="Xamarin.Mac" /> | ||
| <Reference Include="Mono.Data.Tds" /> | ||
| <Reference Include="GuiUnit"> | ||
| <HintPath>..\..\..\external\guiunit\src\framework\obj\Debug\xammac_mobile\GuiUnit.exe</HintPath> |
There was a problem hiding this comment.
Same question here w\ Modern/Mobile as above.
There was a problem hiding this comment.
So, we were having compilation issues in both project because the GuiUnit.exe could not be found, after a tree on the source path we have:
tree -f ../../../external/guiunit/src/framework/ | grep exe
│ ├── ../../../external/guiunit/src/framework/obj/Debug/xammac_mobile/GuiUnit.exe
That is, with the build of the guiunit project we only get the .exe under xammac_mobile. I don't quite know the difference between the /Modern/Mobile but I do know that is the only path with the .exe. Without it, we won't be able to compile the test projects.
|
Build failure |
|
Failure is due to the test result not being correctly converted to NUnit ones. Adding a bug for that regarding jenkins and assigning it to myself: https://bugzilla.xamarin.com/show_bug.cgi?id=60251 |
dotnet#2912) * [macos] Fix guiunit error on clean builds by depending on correct copy - From a clean build making a BCL test would error due to the non-mobile guiunit not being built - This was because the Makefile-mac.inc target was incorrect - This was because xharness assumed that non variation based targets were always Modern - However, BCL tests are Full, not Modern * Code review change * Swap to var to reduce diff
|
Build failure |
|
Build success |
5 participants
No description provided.