-
Notifications
You must be signed in to change notification settings - Fork 554
[runtime] integrate mono 2017-10 #2905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… called mono_profiler_init_log () now.
This is also needed to build with Xcode 8.3 on High Sierra.
- This reverts commit 76b759e. - 2017-08 has linker fix
…ble-test Merge master into 2017-08 and re-enable link-keep-resources-2
This reverts commit bb78327.
…ofiler-log, its called mono_profiler_init_log () now. see mono/mono@ea4e4a9 fixes: ``` 1) Failed : Xamarin.MTouch.Profiling(tvOS) _mono_profiler_startup_log Expected: collection containing "_mono_profiler_startup_log" But was: < "_mono_profiler_init_log" > at Xamarin.MTouch.Profiling (Xamarin.Profile profile) [0x00106] in <511889694a624cc9a50e0e9b259b05c5>:0 2) Failed : Xamarin.MTouch.Profiling(watchOS) _mono_profiler_startup_log Expected: collection containing "_mono_profiler_startup_log" But was: < "_xamarin_get_block_descriptor", "_mono_profiler_init_log" > at Xamarin.MTouch.Profiling (Xamarin.Profile profile) [0x00106] in <511889694a624cc9a50e0e9b259b05c5>:0 ```
mono/mono@826558a deprecated the dash prefix for the mlpd path. `noallocs` or `nocalls` are not needed, neither of them are default anymore.
…ources. another corlib resource (mscorlib.xml) was added: mono/mono@11e95169e787#diff-2d1c64decd91d9a6e8842ab0f0e9438d
…rlib resources." This reverts commit 350eb3c.
the test was failing in that way: > Executing link-keep-resources-2... > [FAIL] i18n 4/2 data files present: charinfo.nlp, collation.core.bin, collation.tailoring.bin, mscorlib.xml also update the output, because it's actually expected at least three elements. fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=59277
|
Build failure |
|
Build failure |
|
@lewurm there are some breaking changes in the BCL: https://jenkins.mono-project.com/job/xamarin-macios-pr-builder/5456/API_diff/, please review those to see if they're expected. |
|
Build failure |
|
Build failure |
1 similar comment
|
Build failure |
|
Build failure |
|
build |
rolfbjarne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good once the breaking API has been reviewed and confirmed to be fine (and QA has approved).
|
The API diff looks good from my POV. The |
|
Build failure |
|
It seems the Jenkins bot might be running out of disk space (https://github.com/xamarin/maccore/issues/570), but with a non-obvious error, so I'm not sure. |
|
build |
|
Build failure |
|
filed a bug for the test failure: https://bugzilla.xamarin.com/show_bug.cgi?id=60570 |
|
https://bugzilla.xamarin.com/show_bug.cgi?id=60540 is unrelated to https://bugzilla.xamarin.com/show_bug.cgi?id=60571 seems a regression that was fixed in |
|
@spouliot https://bugzilla.xamarin.com/show_bug.cgi?id=60571 should be fixed with mono/mono#6005. Let me bump mono on this branch so we can have a build that QA can test |
|
Build failure |
spouliot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm #60571 works fine locally
|
The other issues are unrelated (seems to be an issue running them in parallel on mac). @luhenry unless someone else expressed concerns recently this can be merged into master :) |
either this PR or #2906