Skip to content

[src] Fix UInt64 != long typo in method signature. #3010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfbjarne merged 2 commits into from
Nov 16, 2017
Merged

[src] Fix UInt64 != long typo in method signature. #3010

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0674da5
[src] Fix UInt64 != long typo in method signature.
rolfbjarne Nov 15, 2017
95f2e59
[src] Add Obsolete to incorrect API.
rolfbjarne Nov 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/ObjCRuntime/Dlfcn.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,8 @@ public static ulong GetUInt64 (IntPtr handle, string symbol)
return (ulong) Marshal.ReadInt64 (indirect);
}

#if !XAMCORE_4_0
Copy link
Contributor

@spouliot spouliot Nov 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general we put [Obsolete] on API we plan to remove
not sure it matter much in this case, the compiler should pick up the appropriate one...

Copy link
Member Author

@rolfbjarne rolfbjarne Nov 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@spouliot I've added the [Obsolete].

[Obsolete ("Use 'SetInt64' for long values instead.")]
public static void SetUInt64 (IntPtr handle, string symbol, long value)
{
var indirect = dlsym (handle, symbol);
Expand All @@ -219,6 +221,16 @@ public static void SetUInt64 (IntPtr handle, string symbol, long value)

Marshal.WriteInt64 (indirect, (long) value);
}
#endif

public static void SetUInt64 (IntPtr handle, string symbol, ulong value)
{
var indirect = dlsym (handle, symbol);
if (indirect == IntPtr.Zero)
return;

Marshal.WriteInt64 (indirect, (long) value);
}

public static void SetString (IntPtr handle, string symbol, string value)
{
Expand Down