Added: missing link color

[equinox2k]

Hi,

Was creating binding for Mojave and noticed linkColor was missing for macOS (10,10) and have added.

Going forward what is the process for adding missing bindings, is it a case of using objective sharpie against framework and comparing with the files in repo e.g. AppKit.cs? My current requirement is to update bindings for AppKit + PhotosUI + Photos for Mojave and hoping I can help if I understand the process...

Pete

[chamons]

build

[chamons]

First of all, thanks for the contribution!

If you are interested in working on bindings, I'd suggest dropping by our gitter where we can answer questions.

The macios team is currently working on Mojave specific bindings in the xcode10 branch. We have a list of new APIs that need bound and PRs out for some parts of it already. The 10.14 AppKits APIs have a PR out that I'm working on, and @mandel-macaque is working on Photos/PhotosUI already.

As you've noticed, we don't have 100% API coverage with the older macOS APIs in particular. Our xtro-sharpie test compares our bindings to the headers and our introspection tests compares our bindings to the actual libraries, so we have a pretty good general idea what we're missing. You can see your item on the list here:

https://github.com/xamarin/xamarin-macios/blob/xcode10/tests/xtro-sharpie/macOS-AppKit.todo#L46

If there's a specific API you have interest in binding and isn't currently being worked on by another, drop by gitter and @ me. We can coordinate so we don't have multiple people re-doing either other's work.

[equinox2k]

@chamons Thanks, glad things are in progress and will look into how I can help without duplicating any work. Will see you on bitter :)

[monojenkins]

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Test run failed 🔥

Test results

3 tests failed, 0 tests skipped, 77 tests passed.

Failed tests

• xammac tests/Mac/Debug: Failed (Test run failed.)
• xammac tests/Mac/Release: Failed (Test run failed.)
• xammac tests/Mac/Release (all optimizations): Failed (Test run failed.)

[chamons]

MonoTouchFixtures.Security.RecordTest.DeskCase_83099_InmutableDictionary: Password could not be saved to keychain failures are known https://github.com/xamarin/maccore/issues/868

[chamons]

API Diff / Generator diff look good.

[spouliot]

Hey guys, that went a bit too fast :)

master cannot include beta API and Xcode 9.4 (what's stable today) does not have linkColor defined as a public API in NSColor.

IOW even if it's available on 10.10 Apple can decide to remove it publicly in a later Xcode 10 beta and we'll end up with a broken API / private symbol (potentially blocking App Store submissions).

Now I don't think it's very likely in this specific case but the fact that xtro did not complain about the addition of a missing API is a red flag that we should not ignore (and investigate).

In such case this is better handled to include those API in the xcode10 branch, with a [Mac (10,10)] availability attribute. If Apple change it's mind in a future beta we'll spot it (header diffs) and remove it before it gets release publicly.

[chamons]

Moved it to xcode10 - #4363

[chamons]

Fixed in xcode10 now.