[msbuild] Set 'CopyNuGetImplementations' to true for app extensions. Fixes #4235 and #4237. #4512

rolfbjarne · 2018-07-26T17:17:52Z

In Xamarin.iOS.Common.targets, just before the _CompileToNative target, we
modify the mtouch references to ensure that we get the lib assemblies for
nugets, and not the ref references:

https://github.com/xamarin/xamarin-macios/blob/9e31d07ecc08a64372dd562e843c3d8950d24985/msbuild/Xamarin.iOS.Tasks.Core/Xamarin.iOS.Common.targets#L784-L791

This logic removes nuget references, and then re-adds any copy-local dll
references.

This works fine in executable projects, but not in library projects (aka
extensions), because nugets aren't copied for library projects:

https://github.com/NuGet/NuGet.BuildTasks/blob/cf4b0a12cf1f75e0654f28c2a9020251c41d126a/src/Microsoft.NuGet.Build.Tasks/Microsoft.NuGet.targets#L86

So we need to set the CopyNuGetImplementations variable to 'true' for our
library projects.

Fixes #4235.
Fixes #4237.

…ixes dotnet#4235 and dotnet#4237. In Xamarin.iOS.Common.targets, just before the _CompileToNative target, we modify the mtouch references to ensure that we get the lib assemblies for nugets, and not the ref references: https://github.com/xamarin/xamarin-macios/blob/9e31d07ecc08a64372dd562e843c3d8950d24985/msbuild/Xamarin.iOS.Tasks.Core/Xamarin.iOS.Common.targets#L784-L791 This logic removes nuget references, and then re-adds any copy-local dll references. This works fine in executable projects, but not in library projects (aka extensions), because nugets aren't copied for library projects: https://github.com/NuGet/NuGet.BuildTasks/blob/cf4b0a12cf1f75e0654f28c2a9020251c41d126a/src/Microsoft.NuGet.Build.Tasks/Microsoft.NuGet.targets#L86 So we need to set the CopyNuGetImplementations variable to 'true' for our library projects. Fixes dotnet#4235. Fixes dotnet#4237.

rolfbjarne · 2018-07-26T17:19:04Z

Is there anybody else knowledgable about nugets who can verify that this fix makes sense?

spouliot · 2018-07-26T19:08:36Z

@VincentDondain please have a look since you did the original fix.
@mrward your input wrt nuget would be appreciated too

monojenkins · 2018-07-26T20:51:46Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
✅ Generator Diff (only version changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 0 tests skipped, 81 tests passed.

Failed tests

MSBuild tests/iOS: Failed (Execution failed with exit code 2)

…ckPathsOverride when running msbuild for package reference tests. This fixes a problem where nuget restore would fail for projects with PackageReferences, because a variable would be empty and msbould would try to write to /: nuget restore ../MyAppWithPackageReference/MyAppWithPackageReference.csproj MSBuild auto-detection: using msbuild version '15.0' from '/Library/Frameworks/Mono.framework/Versions/Current/lib/mono/msbuild/15.0/bin/'. Restoring packages for /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/msbuild/tests/MyAppWithPackageReference/MyAppWithPackageReference.csproj... Committing restore... Generating MSBuild file /MyAppWithPackageReference.csproj.nuget.g.props. Path / is a directory This will become unnecessary when PR dotnet#4111 is merged.

monojenkins · 2018-07-27T11:30:27Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
✅ Generator Diff (only version changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 0 tests skipped, 81 tests passed.

Failed tests

MSBuild tests/iOS: Failed (Execution failed with exit code 1)

rolfbjarne · 2018-07-27T11:46:50Z

The new test fails because it requires MSBuild, and MSBuild picks up some assemblies from the system XI, not the locally built one.

IOW the new tests in this PR requires PR #4111, so let's wait a bit to see if we can get that completed.

chamons · 2018-07-27T21:05:42Z

@radical might be a good set of eyes here.

Do we need this hack for Xamarin.Mac?

rolfbjarne · 2018-07-30T08:52:53Z

Do we need this hack for Xamarin.Mac?

Yeah, probably, I'll test it.

VincentDondain

Changes look good to me! Thanks for the test, that's what I wanted to write in my initial PR but I too got blocked by #4111.

chamons · 2018-08-07T20:21:34Z

I've added a XM test showing that somehow (?!?) we don't need a fix for macOS.

This is more than a bit surprising, and I pinged @radical for help understanding for what's going on. I've pushed my test to the PR, please review and see what i'm missing.

monojenkins · 2018-08-08T02:35:27Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
✅ Generator Diff (only version changes)
🔥 Test run failed 🔥

Test results

3 tests failed, 0 tests skipped, 215 tests passed.

Failed tests

System/Mac/Modern: Failed (Test run failed.)
MSBuild tests/iOS: Failed (Execution failed with exit code 1)
mmptest/macOS/All: Failed (Execution failed with exit code 2)

chamons · 2018-08-08T14:48:14Z

I've hopefully un-failed at reading comprehension and added a test that actually uses XM extensions, which still doesn't need a fix (?)

chamons · 2018-08-08T14:49:08Z

tests/mmptest/src/ExtensionTests.cs

 			{
-				string testPath = Path.Combine (TI.FindSourceDirectory (), @"Today/TodayExtensionTest.csproj");
-				TI.BuildProject (testPath, isUnified: true);
+				TI.CopyDirectory (Path.Combine (TI.FindSourceDirectory (), @"Today"), tmpDir);


The extension tests were building in place, which was lazy and wrong of me. Let's copy them to temp.

We also need this since we added a variable to substitute in today.

…ot openable in VSfM

chamons · 2018-08-09T13:45:58Z

It looks like we're failing on nuget restore, (due to not having a way to redirect msbuild?).

In any case, I'll disable the tests for now :(

monojenkins · 2018-08-09T18:07:19Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
✅ Generator Diff (only version changes)
🔥 Test run failed 🔥

Test results

# Test run in progress: Built: 23, Succeeded: 193, Failed: 2, Ignored: 1131

Failed tests

System.Core/watchOS - simulator/Debug: Failed
MSBuild tests/iOS: Failed (Execution failed with exit code 1)

chamons · 2018-08-09T19:26:48Z

build

monojenkins · 2018-08-10T00:20:39Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
✅ Generator Diff (only version changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 0 tests skipped, 217 tests passed.

Failed tests

MSBuild tests/iOS: Failed (Execution failed with exit code 1)

kzu · 2018-08-12T15:22:12Z

Would the new-ish Microsoft.Build.Locator package help with the MSBuild redirection? /cc @rainersigwald

spouliot · 2018-08-15T14:23:32Z

@chamons can you disable the MSBuild/iOS test so we can merge the PR ?
Also create an issue so it (and the Mac ones) can be re-enabled once we can test them properly

chamons · 2018-08-15T15:07:05Z

We already have #4110 open which I refer'ed to in each comment out. When we fix that, we'll have to search for that (along with the original bugzilla number) and comment in a bunch of tests.

I also merged master to fix the merge conflict.

monojenkins · 2018-08-15T18:22:30Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
✅ Generator Diff (only version changes)
🔥 Test run failed 🔥

Test results

Test run in progress: InProgress, Waiting: 1, Built: 145, Running: 1, RunQueued: 49, Succeeded: 22, Ignored: 1131

spouliot · 2018-08-15T19:33:28Z

failure due to disk space

18:20:26 System.IO.IOException: Disk full. Path /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/jenkins-results/tests/MSBuild tests_268/execute-20180815_140058.txt

rolfbjarne · 2018-08-16T15:19:35Z

build

monojenkins · 2018-08-16T19:22:32Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
✅ Generator Diff (only version changes)
🔥 Test run failed 🔥

Test results

# Test run in progress: Built: 113, Succeeded: 101, Failed: 1, Ignored: 1131, Crashed: 3

Failed tests

dont link/iOS Unified 32-bits - simulator/Debug: Crashed
dont link/iOS Unified 32-bits - simulator/Release: Crashed
link all/iOS Unified 32-bits - simulator/Debug: Crashed
MSBuild tests/iOS: Failed (Execution failed with exit code 1)

rolfbjarne · 2018-08-17T09:13:18Z

build

monojenkins · 2018-08-17T13:43:40Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
✅ Generator Diff (only version changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 0 tests skipped, 217 tests passed.

Failed tests

MSBuild tests/iOS: Failed (Execution failed with exit code 1)

Disable tests by using the Ignore attribute, because just commenting out the TestCase attributes makes the test fail: 1) NotRunnable : Xamarin.iOS.Tasks.ProjectReferenceTests.BasicTest No suitable constructor was found

rolfbjarne · 2018-08-20T07:04:52Z

build

monojenkins · 2018-08-20T11:36:04Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
✅ Generator Diff (only version changes)
🔥 Test run failed 🔥

Test results

1 tests failed, 0 tests skipped, 217 tests passed.

Failed tests

fsharp/watchOS - simulator/Debug: Failed

rolfbjarne · 2018-08-20T11:38:53Z

Test failure is unrelated (https://github.com/xamarin/maccore/issues/827, test actually succeeded, the reporting of it failed).

…ixes dotnet#4235 and dotnet#4237. (dotnet#4512) * [msbuild] Set 'CopyNuGetImplementations' to true for app extensions. Fixes dotnet#4235 and dotnet#4237. In Xamarin.iOS.Common.targets, just before the _CompileToNative target, we modify the mtouch references to ensure that we get the lib assemblies for nugets, and not the ref references: https://github.com/xamarin/xamarin-macios/blob/9e31d07ecc08a64372dd562e843c3d8950d24985/msbuild/Xamarin.iOS.Tasks.Core/Xamarin.iOS.Common.targets#L784-L791 This logic removes nuget references, and then re-adds any copy-local dll references. This works fine in executable projects, but not in library projects (aka extensions), because nugets aren't copied for library projects: https://github.com/NuGet/NuGet.BuildTasks/blob/cf4b0a12cf1f75e0654f28c2a9020251c41d126a/src/Microsoft.NuGet.Build.Tasks/Microsoft.NuGet.targets#L86 So we need to set the CopyNuGetImplementations variable to 'true' for our library projects. Fixes dotnet#4235. Fixes dotnet#4237. * [tests] Redirect MSBuildExtensionsPath to MSBuildExtensionsPathFallbackPathsOverride when running msbuild for package reference tests. This fixes a problem where nuget restore would fail for projects with PackageReferences, because a variable would be empty and msbould would try to write to /: nuget restore ../MyAppWithPackageReference/MyAppWithPackageReference.csproj MSBuild auto-detection: using msbuild version '15.0' from '/Library/Frameworks/Mono.framework/Versions/Current/lib/mono/msbuild/15.0/bin/'. Restoring packages for /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/msbuild/tests/MyAppWithPackageReference/MyAppWithPackageReference.csproj... Committing restore... Generating MSBuild file /MyAppWithPackageReference.csproj.nuget.g.props. Path / is a directory This will become unnecessary when PR dotnet#4111 is merged. * Add Xamarin.Mac test showing that fix is not needed (?!?) * Add AppExtension test with packagereference * Make extension actually have json code generated * Fix ProjectTypeGuids of checked in extension projects, as they were not openable in VSfM * XM extension test now correctly fails * Now that we have a failing test, fix XM same as rest of platforms * Disable XM tests due to msbuild redirect sadness * Disable iOS tests as well due to dotnet#4110 * Disable iOS tests by using the Ignore attribute. Disable tests by using the Ignore attribute, because just commenting out the TestCase attributes makes the test fail: 1) NotRunnable : Xamarin.iOS.Tasks.ProjectReferenceTests.BasicTest No suitable constructor was found

…ixes #4235 and #4237. (#4512) (#4648) * [msbuild] Set 'CopyNuGetImplementations' to true for app extensions. Fixes #4235 and #4237. In Xamarin.iOS.Common.targets, just before the _CompileToNative target, we modify the mtouch references to ensure that we get the lib assemblies for nugets, and not the ref references: https://github.com/xamarin/xamarin-macios/blob/9e31d07ecc08a64372dd562e843c3d8950d24985/msbuild/Xamarin.iOS.Tasks.Core/Xamarin.iOS.Common.targets#L784-L791 This logic removes nuget references, and then re-adds any copy-local dll references. This works fine in executable projects, but not in library projects (aka extensions), because nugets aren't copied for library projects: https://github.com/NuGet/NuGet.BuildTasks/blob/cf4b0a12cf1f75e0654f28c2a9020251c41d126a/src/Microsoft.NuGet.Build.Tasks/Microsoft.NuGet.targets#L86 So we need to set the CopyNuGetImplementations variable to 'true' for our library projects. Fixes #4235. Fixes #4237. * [tests] Redirect MSBuildExtensionsPath to MSBuildExtensionsPathFallbackPathsOverride when running msbuild for package reference tests. This fixes a problem where nuget restore would fail for projects with PackageReferences, because a variable would be empty and msbould would try to write to /: nuget restore ../MyAppWithPackageReference/MyAppWithPackageReference.csproj MSBuild auto-detection: using msbuild version '15.0' from '/Library/Frameworks/Mono.framework/Versions/Current/lib/mono/msbuild/15.0/bin/'. Restoring packages for /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/msbuild/tests/MyAppWithPackageReference/MyAppWithPackageReference.csproj... Committing restore... Generating MSBuild file /MyAppWithPackageReference.csproj.nuget.g.props. Path / is a directory This will become unnecessary when PR #4111 is merged. * Add Xamarin.Mac test showing that fix is not needed (?!?) * Add AppExtension test with packagereference * Make extension actually have json code generated * Fix ProjectTypeGuids of checked in extension projects, as they were not openable in VSfM * XM extension test now correctly fails * Now that we have a failing test, fix XM same as rest of platforms * Disable XM tests due to msbuild redirect sadness * Disable iOS tests as well due to #4110 * Disable iOS tests by using the Ignore attribute. Disable tests by using the Ignore attribute, because just commenting out the TestCase attributes makes the test fail: 1) NotRunnable : Xamarin.iOS.Tasks.ProjectReferenceTests.BasicTest No suitable constructor was found

…ixes dotnet#4235 and dotnet#4237. (dotnet#4512) (dotnet#4648) * [msbuild] Set 'CopyNuGetImplementations' to true for app extensions. Fixes dotnet#4235 and dotnet#4237. In Xamarin.iOS.Common.targets, just before the _CompileToNative target, we modify the mtouch references to ensure that we get the lib assemblies for nugets, and not the ref references: https://github.com/xamarin/xamarin-macios/blob/9e31d07ecc08a64372dd562e843c3d8950d24985/msbuild/Xamarin.iOS.Tasks.Core/Xamarin.iOS.Common.targets#L784-L791 This logic removes nuget references, and then re-adds any copy-local dll references. This works fine in executable projects, but not in library projects (aka extensions), because nugets aren't copied for library projects: https://github.com/NuGet/NuGet.BuildTasks/blob/cf4b0a12cf1f75e0654f28c2a9020251c41d126a/src/Microsoft.NuGet.Build.Tasks/Microsoft.NuGet.targets#L86 So we need to set the CopyNuGetImplementations variable to 'true' for our library projects. Fixes dotnet#4235. Fixes dotnet#4237. * [tests] Redirect MSBuildExtensionsPath to MSBuildExtensionsPathFallbackPathsOverride when running msbuild for package reference tests. This fixes a problem where nuget restore would fail for projects with PackageReferences, because a variable would be empty and msbould would try to write to /: nuget restore ../MyAppWithPackageReference/MyAppWithPackageReference.csproj MSBuild auto-detection: using msbuild version '15.0' from '/Library/Frameworks/Mono.framework/Versions/Current/lib/mono/msbuild/15.0/bin/'. Restoring packages for /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/msbuild/tests/MyAppWithPackageReference/MyAppWithPackageReference.csproj... Committing restore... Generating MSBuild file /MyAppWithPackageReference.csproj.nuget.g.props. Path / is a directory This will become unnecessary when PR dotnet#4111 is merged. * Add Xamarin.Mac test showing that fix is not needed (?!?) * Add AppExtension test with packagereference * Make extension actually have json code generated * Fix ProjectTypeGuids of checked in extension projects, as they were not openable in VSfM * XM extension test now correctly fails * Now that we have a failing test, fix XM same as rest of platforms * Disable XM tests due to msbuild redirect sadness * Disable iOS tests as well due to dotnet#4110 * Disable iOS tests by using the Ignore attribute. Disable tests by using the Ignore attribute, because just commenting out the TestCase attributes makes the test fail: 1) NotRunnable : Xamarin.iOS.Tasks.ProjectReferenceTests.BasicTest No suitable constructor was found

spouliot · 2018-09-05T12:17:17Z

@monojenkins backport to xcode10

…ixes dotnet#4235 and dotnet#4237. (dotnet#4512) (dotnet#4648) * [msbuild] Set 'CopyNuGetImplementations' to true for app extensions. Fixes dotnet#4235 and dotnet#4237. In Xamarin.iOS.Common.targets, just before the _CompileToNative target, we modify the mtouch references to ensure that we get the lib assemblies for nugets, and not the ref references: https://github.com/xamarin/xamarin-macios/blob/9e31d07ecc08a64372dd562e843c3d8950d24985/msbuild/Xamarin.iOS.Tasks.Core/Xamarin.iOS.Common.targets#L784-L791 This logic removes nuget references, and then re-adds any copy-local dll references. This works fine in executable projects, but not in library projects (aka extensions), because nugets aren't copied for library projects: https://github.com/NuGet/NuGet.BuildTasks/blob/cf4b0a12cf1f75e0654f28c2a9020251c41d126a/src/Microsoft.NuGet.Build.Tasks/Microsoft.NuGet.targets#L86 So we need to set the CopyNuGetImplementations variable to 'true' for our library projects. Fixes dotnet#4235. Fixes dotnet#4237. * [tests] Redirect MSBuildExtensionsPath to MSBuildExtensionsPathFallbackPathsOverride when running msbuild for package reference tests. This fixes a problem where nuget restore would fail for projects with PackageReferences, because a variable would be empty and msbould would try to write to /: nuget restore ../MyAppWithPackageReference/MyAppWithPackageReference.csproj MSBuild auto-detection: using msbuild version '15.0' from '/Library/Frameworks/Mono.framework/Versions/Current/lib/mono/msbuild/15.0/bin/'. Restoring packages for /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/msbuild/tests/MyAppWithPackageReference/MyAppWithPackageReference.csproj... Committing restore... Generating MSBuild file /MyAppWithPackageReference.csproj.nuget.g.props. Path / is a directory This will become unnecessary when PR dotnet#4111 is merged. * Add Xamarin.Mac test showing that fix is not needed (?!?) * Add AppExtension test with packagereference * Make extension actually have json code generated * Fix ProjectTypeGuids of checked in extension projects, as they were not openable in VSfM * XM extension test now correctly fails * Now that we have a failing test, fix XM same as rest of platforms * Disable XM tests due to msbuild redirect sadness * Disable iOS tests as well due to dotnet#4110 * Disable iOS tests by using the Ignore attribute. Disable tests by using the Ignore attribute, because just commenting out the TestCase attributes makes the test fail: 1) NotRunnable : Xamarin.iOS.Tasks.ProjectReferenceTests.BasicTest No suitable constructor was found

…ixes #4235 and #4237. (#4512) (#4648) (#4773) In Xamarin.iOS.Common.targets, just before the _CompileToNative target, we modify the mtouch references to ensure that we get the lib assemblies for nugets, and not the ref references: https://github.com/xamarin/xamarin-macios/blob/9e31d07ecc08a64372dd562e843c3d8950d24985/msbuild/Xamarin.iOS.Tasks.Core/Xamarin.iOS.Common.targets#L784-L791 This logic removes nuget references, and then re-adds any copy-local dll references. This works fine in executable projects, but not in library projects (aka extensions), because nugets aren't copied for library projects: https://github.com/NuGet/NuGet.BuildTasks/blob/cf4b0a12cf1f75e0654f28c2a9020251c41d126a/src/Microsoft.NuGet.Build.Tasks/Microsoft.NuGet.targets#L86 So we need to set the CopyNuGetImplementations variable to 'true' for our library projects. Fixes #4235. Fixes #4237. * [tests] Redirect MSBuildExtensionsPath to MSBuildExtensionsPathFallbackPathsOverride when running msbuild for package reference tests. This fixes a problem where nuget restore would fail for projects with PackageReferences, because a variable would be empty and msbould would try to write to /: nuget restore ../MyAppWithPackageReference/MyAppWithPackageReference.csproj MSBuild auto-detection: using msbuild version '15.0' from '/Library/Frameworks/Mono.framework/Versions/Current/lib/mono/msbuild/15.0/bin/'. Restoring packages for /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/msbuild/tests/MyAppWithPackageReference/MyAppWithPackageReference.csproj... Committing restore... Generating MSBuild file /MyAppWithPackageReference.csproj.nuget.g.props. Path / is a directory This will become unnecessary when PR #4111 is merged. * Add Xamarin.Mac test showing that fix is not needed (?!?) * Add AppExtension test with packagereference * Make extension actually have json code generated * Fix ProjectTypeGuids of checked in extension projects, as they were not openable in VSfM * XM extension test now correctly fails * Now that we have a failing test, fix XM same as rest of platforms * Disable XM tests due to msbuild redirect sadness * Disable iOS tests as well due to #4110 * Disable iOS tests by using the Ignore attribute. Disable tests by using the Ignore attribute, because just commenting out the TestCase attributes makes the test fail: 1) NotRunnable : Xamarin.iOS.Tasks.ProjectReferenceTests.BasicTest No suitable constructor was found

rolfbjarne requested review from VincentDondain, emaf, jstedfast and kzu as code owners July 26, 2018 17:17

spouliot approved these changes Jul 26, 2018

View reviewed changes

jstedfast approved these changes Jul 26, 2018

View reviewed changes

mrward requested a review from radical July 27, 2018 09:04

mrward approved these changes Jul 27, 2018

View reviewed changes

emaf approved these changes Jul 27, 2018

View reviewed changes

VincentDondain approved these changes Jul 31, 2018

View reviewed changes

Add Xamarin.Mac test showing that fix is not needed (?!?)

5d3f60c

mandel-macaque approved these changes Aug 8, 2018

View reviewed changes

Add AppExtension test with packagereference

c7f6937

chamons reviewed Aug 8, 2018

View reviewed changes

chamons added 4 commits August 8, 2018 09:58

Make extension actually have json code generated

c8152a3

Fix ProjectTypeGuids of checked in extension projects, as they were n…

b5eb803

…ot openable in VSfM

XM extension test now correctly fails

cd06352

Now that we have a failing test, fix XM same as rest of platforms

1636e15

Disable XM tests due to msbuild redirect sadness

8b73f51

chamons added 2 commits August 15, 2018 11:04

Disable iOS tests as well due to dotnet#4110

52a2e0c

Merge branch 'master' into issue-4235

48663f6

Disable iOS tests by using the Ignore attribute.

873760e

Disable tests by using the Ignore attribute, because just commenting out the TestCase attributes makes the test fail: 1) NotRunnable : Xamarin.iOS.Tasks.ProjectReferenceTests.BasicTest No suitable constructor was found

rolfbjarne merged commit a619226 into dotnet:master Aug 20, 2018

rolfbjarne mentioned this pull request Aug 20, 2018

[msbuild] Set 'CopyNuGetImplementations' to true for app extensions. Fixes #4235 and #4237. (#4512) #4648

Merged

spouliot mentioned this pull request Sep 7, 2018

[msbuild] Set 'CopyNuGetImplementations' to true for app extensions. Fixes #4235 and #4237. (#4512) (#4648) #4773

Merged

[msbuild] Set 'CopyNuGetImplementations' to true for app extensions. Fixes #4235 and #4237. #4512

[msbuild] Set 'CopyNuGetImplementations' to true for app extensions. Fixes #4235 and #4237. #4512

Uh oh!

Conversation

rolfbjarne commented Jul 26, 2018

Uh oh!

rolfbjarne commented Jul 26, 2018

Uh oh!

spouliot commented Jul 26, 2018

Uh oh!

monojenkins commented Jul 26, 2018

Test results

Failed tests

Uh oh!

monojenkins commented Jul 27, 2018

Test results

Failed tests

Uh oh!

rolfbjarne commented Jul 27, 2018

Uh oh!

chamons commented Jul 27, 2018

Uh oh!

rolfbjarne commented Jul 30, 2018

Uh oh!

VincentDondain left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chamons commented Aug 7, 2018

Uh oh!

monojenkins commented Aug 8, 2018

Test results

Failed tests

Uh oh!

chamons commented Aug 8, 2018

Uh oh!

chamons Aug 8, 2018

Choose a reason for hiding this comment

Uh oh!

chamons commented Aug 9, 2018

Uh oh!

monojenkins commented Aug 9, 2018

Test results

Failed tests

Uh oh!

chamons commented Aug 9, 2018

Uh oh!

monojenkins commented Aug 10, 2018

Test results

Failed tests

Uh oh!

kzu commented Aug 12, 2018

Uh oh!

spouliot commented Aug 15, 2018

Uh oh!

chamons commented Aug 15, 2018

Uh oh!

monojenkins commented Aug 15, 2018

Test results

Test run in progress: InProgress, Waiting: 1, Built: 145, Running: 1, RunQueued: 49, Succeeded: 22, Ignored: 1131

Uh oh!

spouliot commented Aug 15, 2018

Uh oh!

rolfbjarne commented Aug 16, 2018

Uh oh!

monojenkins commented Aug 16, 2018

Test results

Failed tests

Uh oh!

rolfbjarne commented Aug 17, 2018

Uh oh!

monojenkins commented Aug 17, 2018

Test results

Failed tests

Uh oh!

rolfbjarne commented Aug 20, 2018

Uh oh!

monojenkins commented Aug 20, 2018

Test results

Failed tests

VincentDondain left a comment •

edited

Loading