[uikit] Duplicate bindings for 'UIScrollView.ContentOffset' to get correct availability information. Fixes #4893 #4982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrect availability information. Fixes dotnet#4893 `ContentOffset` was moved to `UIFocusItemScrollableContainer` in iOS 12. Since it's a new protocol it's decorated as introduced in iOS 12 - but the API was actually already available for a long time. The _trick_ is to keep the original binding inside `UIScrollView` so it overrides the protocol and keeps the correct availability info. It requires adding `new` to bindings to avoid compiler warnings. reference: dotnet#4893
spouliot
requested review from
VincentDondain,
dalexsoto and
rolfbjarne
as code owners
Collaborator
|
Build success |
rolfbjarne
approved these changes
Oct 15, 2018
mandel-macaque
approved these changes
Oct 15, 2018
Member
|
@monojenkins backport master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContentOffsetwas moved toUIFocusItemScrollableContainerin iOS 12.Since it's a new protocol it's decorated as introduced in iOS 12 - but
the API was actually already available for a long time.
The trick is to keep the original binding inside
UIScrollViewso it overrides the protocol and keeps the correct availability info.
It requires adding
newto bindings to avoid compiler warnings.reference: #4893