[d16-0 P3] Merge pull request #5402 from migueldeicaza/fix-uigesturerecognizer-r… #5414
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…izer-regression [UIKit] UIGestureRecognizer's custon OnDispose method needs to queue the actual operation on the main thread
chamons
added
do-not-merge
dalexsoto
approved these changes
Jan 15, 2019
VincentDondain
suggested changes
Jan 15, 2019
Contributor
VincentDondain
left a comment
VincentDondain
left a comment
There was a problem hiding this comment.
Let us get the test fix in this PR before merging. See: #5402 (comment)
Collaborator
|
Build success |
rolfbjarne
approved these changes
Jan 16, 2019
Member
rolfbjarne
left a comment
rolfbjarne
left a comment
There was a problem hiding this comment.
👍 once the failing test is fixed.
chamons
removed
do-not-merge
Contributor
Author
|
#5488 went in to "fix" test failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…egression
[UIKit] UIGestureRecognizer's custon OnDispose method needs to queue the actual operation on the main thread
#5388