[Foundation] Remove possible race condition with the NSUrlSessionHandler. Fixes #5511 #5557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…der. Fixes dotnet#5511 The SendAsync method in the NSUtlSessionHandler is not handling the cancellation token correctly. Moving the Register to nearly the end of the method (just before returning the task) ensures that if we got a already cancelled token, we execute in a sync manner the cleanup. Using the IsCancellationRequested in this method is less optimal because we would have to check several times: 1. When SencAsync receives the token and before it creates the inflight data. 2. When we are going to resume the data. Since we might have created the inflight data and at that point an other thread cancelled the request. Fixes: dotnet#5511
mandel-macaque
requested review from
chamons,
rolfbjarne and
spouliot
as code owners
Contributor
Author
|
This PR provides the similar behaviour to PR #5334 as well as it ensures that if the token is cancelled at some other point in time while executing SendAsync it is respected. I believe this is a nicer fix. |
rolfbjarne
changed the title
rolfbjarne
approved these changes
Feb 6, 2019
Collaborator
|
Build success |
spouliot
approved these changes
Feb 6, 2019
chamons
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SendAsync method in the NSUrlSessionHandler is not handling the
cancellation token correctly. Moving the Register to nearly the end of
the method (just before returning the task) ensures that if we got a
already cancelled token, we execute in a sync manner the cleanup.
Using the IsCancellationRequested in this method is less optimal
because we would have to check several times:
data.
inflight data and at that point an other thread cancelled the request.
Fixes: #5511