[d16-2] [linker] Add the custom attributes removal step as an configurable optimization. Fix #3655#6058
Merged
spouliot merged 3 commits intodotnet:d16-2from May 16, 2019
Conversation
…timization. Fix dotnet#3655 This allows the optimization to be disabled in cases where one, or many, a custom attribute(s) are required by the application at runtime. While not ideal disabling this single step is much better than disabling linking for the whole application. A better approach is described in dotnet#6048 but this configuration optimization makes sense independently of it. Fix dotnet#3655
Co-Authored-By: Rolf Bjarne Kvinge <rolf@xamarin.com>
monojenkins
requested review from
chamons,
rolfbjarne and
spouliot
as code owners
spouliot
added
the
requires-approval-before-merge
rolfbjarne
approved these changes
May 16, 2019
Contributor
Author
|
Build success |
bholmes
approved these changes
May 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows the optimization to be disabled in cases where one, or
many, a custom attribute(s) are required by the application at runtime.
While not ideal disabling this single step is much better than disabling
linking for the whole application.
A better approach is described in #6048
but this configuration optimization makes sense independently of it.
Fix #3655
Backport of #6049.
/cc @spouliot