Replace Mono submodule with binary artifacts from mono sdks download #6097

akoeplinger · 2019-05-21T20:42:29Z

No description provided.

…ic instead of our own. (#5962)" (#5971)" This reverts commit cb1ead3.

Otherwise things wouldn't get rebuild when Mono is bumped.

Also remove other xunit assembly since we get the from nuget PackageReference already.

# Conflicts: # builds/Makefile # external/mono

…projs

We can't set IGNORE_PROVISION_LLVM=1 anymore

To make sure we correctly propagate the values from xamarin-macios.

wrong sdk version was fixed

monojenkins · 2019-05-29T10:48:19Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
🔥 Test run failed 🔥

Test results

3 tests failed, 166 tests passed.

Failed tests

[xUnit] Mono SystemXmlXunit/watchOS 32-bits - simulator/Debug: Crashed
introspection/watchOS 32-bits - simulator/Debug (watchOS 2.0): Crashed
MTouch tests/NUnit: Failed (Execution failed with exit code 1)

…versions. We don't need 7z installed to just run the tests.

rolfbjarne · 2019-05-29T11:06:36Z

Interesting timings from internal Jenkins:

Checkout: 29s
Build: 6m56s
Packaging: 8m30s
Signing: 7s
Upload to Azure: 1m42s

This means we'll have a build done and packages available within 20 minutes of pushing a new commit.

spouliot

likely too late/big for d16-2 but we should cherry-pick it into xcode11 iif we can get something to work with a different (beta) Xcode

monojenkins · 2019-05-29T15:14:19Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
🔥 Test run failed 🔥

Test results

3 tests failed, 166 tests passed.

Failed tests

link all/Mac/Debug: Failed (Test run failed.)
introspection/watchOS 32-bits - simulator/Debug (watchOS 2.0): Crashed
MTouch tests/NUnit: Failed (Execution failed with exit code 1)

xamarin-release-manager · 2019-05-29T15:22:53Z

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Running XM tests on '10.10', Running XM tests on '10.10'' 🔥

✅ Build succeeded
✅ Packages: xamarin.ios-12.15.0.175.pkg xamarin.mac-5.15.0.175.pkg
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Xamarin.Mac tests on 10.10 failed: Xamarin.Mac tests on macOS 10.10 failed (xammac_tests) 🔥
🔥 Test run failed 🔥

Test results

3 tests failed, 167 tests passed.

Failed tests

monotouch-test/watchOS 32-bits - simulator/Debug: Crashed
introspection/watchOS 32-bits - simulator/Debug (watchOS 2.0): Crashed
MTouch tests/NUnit: Failed (Execution failed with exit code 1)

monojenkins · 2019-05-30T09:39:34Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
🔥 Test run failed 🔥

Test results

3 tests failed, 166 tests passed.

Failed tests

mscorlib/iOS Unified 32-bits - simulator/Debug: Failed
introspection/watchOS 32-bits - simulator/Debug (watchOS 2.0): Crashed
Generator tests/NUnit: Failed (Execution failed with exit code 1)

xamarin-release-manager · 2019-05-30T09:45:42Z

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Running XM tests on '10.10', Running XM tests on '10.13', Running XM tests on '10.13'' 🔥

✅ Build succeeded
✅ Packages: xamarin.ios-12.15.0.181.pkg xamarin.mac-5.15.0.181.pkg
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
ℹ️ Generator Diff (please review changes)
🔥 Xamarin.Mac tests on 10.10 failed: Xamarin.Mac tests on macOS 10.10 failed (xammac_tests) 🔥
🔥 Xamarin.Mac tests on 10.13 failed: Xamarin.Mac tests on macOS 10.13 failed (xammac_tests) 🔥
🔥 Test run failed 🔥

Test results

3 tests failed, 167 tests passed.

Failed tests

[NUnit] Mono SystemXmlTests/watchOS 32-bits - simulator/Debug: Crashed
introspection/watchOS 32-bits - simulator/Debug (watchOS 2.0): Crashed
Generator tests/NUnit: Failed (Execution failed with exit code 1)

rolfbjarne · 2019-05-30T12:10:06Z

Test failures are unrelated.

On public Jenkins:

mscorlib/iOS Unified 32-bits - simulator/Debug: https://github.com/xamarin/maccore/issues/1630
introspection/watchOS 32-bits - simulator/Debug (watchOS 2.0): https://github.com/xamarin/maccore/issues/581
Generator tests/NUnit: https://github.com/xamarin/maccore/issues/1661

On internal Jenkins:

Xamarin.Mac tests on 10.10: https://github.com/xamarin/maccore/issues/1645
Xamarin.Mac tests on 10.13: https://github.com/xamarin/maccore/issues/1663
[NUnit] Mono SystemXmlTests/watchOS 32-bits - simulator/Debug: https://github.com/xamarin/maccore/issues/581
introspection/watchOS 32-bits - simulator/Debug (watchOS 2.0): https://github.com/xamarin/maccore/issues/581
Generator tests/NUnit: https://github.com/xamarin/maccore/issues/1661

monojenkins · 2019-05-30T13:23:04Z

Build failure

!!! Couldn't read commit file !!!

xamarin-release-manager · 2019-05-30T16:35:26Z

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Running XM tests on '10.13', Running XM tests on '10.10', Running XM tests on '10.10'' 🔥

✅ Build succeeded
✅ Packages: xamarin.ios-12.15.0.183.pkg xamarin.mac-5.15.0.183.pkg
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Xamarin.Mac tests on 10.13 failed: Xamarin.Mac tests on macOS 10.13 failed (xammac_tests) 🔥
🔥 Xamarin.Mac tests on 10.10 failed: Xamarin.Mac tests on macOS 10.10 failed (xammac_tests) 🔥
🔥 Test run failed 🔥

Test results

4 tests failed, 166 tests passed.

Failed tests

[NUnit] Mono SystemJsonTests/watchOS 32-bits - simulator/Debug: Crashed
[xUnit] Mono SystemNetHttpUnitTestsXunit/watchOS 32-bits - simulator/Debug: Crashed
introspection/watchOS 32-bits - simulator/Debug (watchOS 2.0): Crashed
Generator tests/NUnit: Failed (Execution failed with exit code 1)

akoeplinger added 2 commits May 21, 2019 22:16

Revert "Revert "[builds] Make the tools build use mono's packaged log…

824174a

…ic instead of our own. (#5962)" (#5971)" This reverts commit cb1ead3.

Switch to mono archive and remove submodule

247a6bf

This comment has been minimized.

Sign in to view

Provision 7z

c842df7

akoeplinger force-pushed the binary-artifacts branch from f15c762 to c842df7 Compare May 21, 2019 23:17

akoeplinger added run-bcl-tests Run the BCL tests run-all-tests Run all our tests. labels May 21, 2019

This comment has been minimized.

Sign in to view

rolfbjarne added the skip-device-tests Skip device tests label May 22, 2019

akoeplinger added 6 commits May 22, 2019 16:17

Bump mono

1a4b56e

Add missing dependencies on Make.config

5020fbc

Otherwise things wouldn't get rebuild when Mono is bumped.

BCLTests: use Xunit.NetCore.Extensions from the mono archive

5ba7fc4

Also remove other xunit assembly since we get the from nuget PackageReference already.

Remove unnecessary test projects

fb16b9b

Fix generator tests

ff7abc7

Merge remote-tracking branch 'upstream/master' into binary-artifacts

48b3b82

# Conflicts: # builds/Makefile # external/mono

This comment has been minimized.

Sign in to view

rolfbjarne added the run-internal-tests If tests should be executed on the internal Jenkins instance. label May 23, 2019

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'upstream/master' into binary-artifacts

776d405

akoeplinger mentioned this pull request May 23, 2019

[builds] Don't reference makefiles from the mono repository when using the mono archive. #5970

Closed

akoeplinger added 3 commits May 24, 2019 01:36

Bump Mono

c7e1b1e

Fix BCLTests projects to use xunit.execution.dotnet.dll from mono

42b4b38

Use correct min version for libmono-native-compat in ProductTests

a239560

akoeplinger marked this pull request as ready for review May 24, 2019 00:21

akoeplinger requested review from VincentDondain, chamons, dalexsoto, rolfbjarne and spouliot as code owners May 24, 2019 00:21

akoeplinger added 5 commits May 27, 2019 18:16

PR feedback, remove unnecessary setting of MONO_IOS_SDK_DESTDIR in cs…

d4f2b02

…projs

Fix source build of Mono

0116641

We can't set IGNORE_PROVISION_LLVM=1 anymore

Set MACOS_VERSION and WATCHOS5_VERSION in the Mono SDKs config

ebb83d1

To make sure we correctly propagate the values from xamarin-macios.

Bump mono

438813f

Merge remote-tracking branch 'upstream/master' into binary-artifacts

e9e7b83

This comment has been minimized.

Sign in to view

rolfbjarne mentioned this pull request May 28, 2019

Add symlink that points to current mono sdks dir #6146

Merged

akoeplinger added 2 commits May 28, 2019 21:43

Merge remote-tracking branch 'upstream/master' into binary-artifacts

b8b79b0

Bump mono

550a340

This comment has been minimized.

Sign in to view

Merge remote-tracking branch 'origin/master' into binary-artifacts

b5958e8

This comment has been minimized.

Sign in to view

[jenkins] Ignore the 7z dependency when running tests on older macOS …

2ac3008

…versions. We don't need 7z installed to just run the tests.

This comment has been minimized.

Sign in to view

spouliot approved these changes May 29, 2019

View reviewed changes

Merge remote-tracking branch 'origin/master' into binary-artifacts

72d7a8a

Merge remote-tracking branch 'origin/master' into binary-artifacts

dfc75ff

rolfbjarne merged commit e89c327 into master May 30, 2019

akoeplinger deleted the binary-artifacts branch May 30, 2019 13:14

Replace Mono submodule with binary artifacts from mono sdks download #6097

Replace Mono submodule with binary artifacts from mono sdks download #6097

Uh oh!

Conversation

akoeplinger commented May 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

monojenkins commented May 29, 2019

Test results

Failed tests

Uh oh!

This comment has been minimized.

rolfbjarne commented May 29, 2019

Uh oh!

spouliot left a comment

Choose a reason for hiding this comment

Uh oh!

monojenkins commented May 29, 2019

Test results

Failed tests

Uh oh!

xamarin-release-manager commented May 29, 2019

Test results

Failed tests

Uh oh!

monojenkins commented May 30, 2019

Test results

Failed tests

Uh oh!

xamarin-release-manager commented May 30, 2019

Test results

Failed tests

Uh oh!

rolfbjarne commented May 30, 2019

Uh oh!

monojenkins commented May 30, 2019

Uh oh!

xamarin-release-manager commented May 30, 2019

Test results

Failed tests

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

akoeplinger commented May 21, 2019 •

edited

Loading