[d16-2] Implement support for ARM64_32. Fixes #4864. #6100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we now have support for ARM64_32.
…nctionNames when LLVM is enabled.
…tchOS/arm64_32 slices.
ARM64_32 only supports the unified native mode.
…s enabled. We don't want to try to run arm64_32 tests on bots that don't have devices attached, so make sure they follow the logic of other device tests.
* Choose the first hostname for the HttpTextWriter if there are multiple hosts. * Open the HttpTextWriter before writing to it. * Don't overwrite the http writer with another writer immediately after creating it. * Close the HttpTextWriter when done writing. * Wait for the HttpTextWriter to complete the final http request before exiting.
Makes them much smaller.
New commits in mono/mono: * mono/mono@16c6ac81b39 [interp] disable inlining for built-in types (dotnet#14531) * mono/mono@1ce13bb09d4 [arm] one more attempt to fix slotsize issue on llvmonly (dotnet#14444) (dotnet#14535) * mono/mono@bb3c9db4976 [2019-02] [monodroid] Introduce 'win32 host' BCL build (dotnet#14504) * mono/mono@ca17767758c [sdks] Set PATH in Android Windows SDK pipeline job (dotnet#14519) * mono/mono@1cb80e7ecfc [sdks] Set win-amd64 CI_TAGS for windows pipeline step (dotnet#14516) * mono/mono@c857c27d2e5 [2019-02][sdks] Build Android SDK on Windows (dotnet#14472) * mono/mono@ab378434b96 [2019-02][ci] Add Android Windows (Release) archive job to pipeline (dotnet#14503) Diff: https://github.com/mono/mono/compare/06c3f553122b17457147695475957ead3ec90b6a..16c6ac81b39bdb26786c2fda155a0a3500961798
rolfbjarne
requested review from
VincentDondain,
chamons,
dalexsoto,
emaf,
jstedfast,
kzu and
spouliot
as code owners
5 tasks
Contributor
|
@rolfbjarne have you run the submission tests on the original PR/packages ? |
Member
Author
No, I'll do that on the master packages and post the results here. |
rolfbjarne
changed the title
Collaborator
|
Build failure Test results2 tests failed, 0 tests' device not found, 229 tests passed.Failed tests
|
Member
Author
|
Test failures are unrelated, both are due to https://github.com/xamarin/maccore/issues/581. |
bholmes
approved these changes
May 22, 2019
dalexsoto
approved these changes
May 22, 2019
Contributor
|
While looking at XM/QTKit (#6039) I executed the submission tests (for master) and that also confirmed the original PR (on master) is fine. |
spouliot
approved these changes
May 22, 2019
Member
Author
Thanks! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is best reviewed commit-by-commit.
Fixes #4864.
Backport of #6040.