Skip to content

Bump maccore and macios-binaries to get fix for #6216. #6229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rolfbjarne merged 1 commit into from
Jun 11, 2019
Merged

Bump maccore and macios-binaries to get fix for #6216. #6229

rolfbjarne merged 1 commit into from
Jun 11, 2019

Conversation

@rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Jun 10, 2019 •
edited
Loading

@rolfbjarne rolfbjarne added the run-internal-tests If tests should be executed on the internal Jenkins instance. label Jun 10, 2019
@monojenkins
Copy link
Collaborator

monojenkins commented Jun 10, 2019

Build failure
✅ Build succeeded
✅ API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
    ** Error: Working directory isn't clean:
    HEAD detached at f46f732
    Untracked files:
    (use "git add ..." to include in what will be committed)
    
    tests/bcl-test/BCL tests group 1.csproj
    tests/bcl-test/BCL tests group 2.csproj
    tests/bcl-test/BCL tests group 3.csproj
    tests/bcl-test/BCL tests group 4.csproj
    tests/bcl-test/BCL tests group 6.csproj
    tests/bcl-test/Mac OS X BCL tests group 1-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 1-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 2-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 2-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 3-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 3-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 4-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 4-mac-modern.csproj
    tests/bcl-test/generated/
    tests/bcl-test/mscorlib-mac-full.csproj
    tests/bcl-test/mscorlib-mac-modern.csproj
    tests/bcl-test/mscorlib.csproj
    
    nothing added to commit but untracked files present (use "git add" to track)
    Search for Comparing API & creating generator diff in the log to view the complete log.
🔥 Test run failed 🔥

Test results

6 tests failed, 88 tests passed.

Failed tests

  • monotouch-test/iOS Unified 64-bits - simulator/Debug: Failed
  • monotouch-test/iOS Unified 64-bits - simulator/Debug (LinkSdk): Failed
  • monotouch-test/tvOS - simulator/Debug: Failed
  • monotouch-test/tvOS - simulator/Debug (static registrar): Failed
  • monotouch-test/tvOS - simulator/Release (all optimizations): Failed
  • monotouch-test/watchOS 32-bits - simulator/Debug: Failed

@rolfbjarne
Copy link
Member Author

rolfbjarne commented Jun 10, 2019

Test failures on public Jenkins are all due to https://github.com/xamarin/maccore/issues/1725 (and unrelated).

@xamarin-release-manager

This comment has been minimized.

Sign in to view
@xamarin-release-manager
Copy link
Collaborator

xamarin-release-manager commented Jun 11, 2019

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥

✅ Build succeeded
✅ Packages: xamarin.ios-12.15.0.215.pkg xamarin.mac-5.15.0.215.pkg
✅ API Diff (from stable)
🔥 Failed to compare API and create generator diff 🔥
    ** Error: Working directory isn't clean:
    HEAD detached at 4103cfd
    Untracked files:
    (use "git add ..." to include in what will be committed)
    
    tests/bcl-test/BCL tests group 1.csproj
    tests/bcl-test/BCL tests group 2.csproj
    tests/bcl-test/BCL tests group 3.csproj
    tests/bcl-test/BCL tests group 4.csproj
    tests/bcl-test/BCL tests group 6.csproj
    tests/bcl-test/Mac OS X BCL tests group 1-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 1-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 2-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 2-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 3-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 3-mac-modern.csproj
    tests/bcl-test/Mac OS X BCL tests group 4-mac-full.csproj
    tests/bcl-test/Mac OS X BCL tests group 4-mac-modern.csproj
    tests/bcl-test/generated/
    tests/bcl-test/mscorlib-mac-full.csproj
    tests/bcl-test/mscorlib-mac-modern.csproj
    tests/bcl-test/mscorlib.csproj
    
    nothing added to commit but untracked files present (use "git add" to track)
    Search for Comparing API & creating generator diff in the log to view the complete log.
🔥 Test run failed 🔥

Test results

7 tests failed, 164 tests passed.

Failed tests

  • monotouch-test/tvOS - simulator/Debug (LinkSdk): Failed
  • monotouch-test/tvOS - simulator/Debug (static registrar): Failed
  • monotouch-test/tvOS - simulator/Debug (all optimizations): Failed
  • [xUnit] Mono SystemXunit/watchOS 32-bits - simulator/Debug: Crashed
  • monotouch-test/watchOS 32-bits - simulator/Debug (LinkSdk): Failed
  • monotouch-test/watchOS 32-bits - simulator/Debug (static registrar): Failed
  • introspection/watchOS 32-bits - simulator/Debug (watchOS 2.0): Crashed

@rolfbjarne
Copy link
Member Author

rolfbjarne commented Jun 11, 2019 •
edited
Loading

Test failures are unrelated.

Api diff failure: https://github.com/xamarin/maccore/issues/1720

@rolfbjarne rolfbjarne merged commit f25d591 into master Jun 11, 2019
mandel-macaque pushed a commit that referenced this pull request Jun 11, 2019
@rolfbjarne @mandel-macaque
Bump maccore and macios-binaries to get fix for #6216. (#6229)
ff13232 
maccore diff: https://github.com/xamarin/maccore/compare/454450958e601857ce244ccaa9a2f1a377dabc87..4cca112bc12be50ff3415652147e7e72eaea14e5

New commits in xamarin/macios-binaries:

* xamarin/macios-binaries@b474fa2 Bump mlaunch to xamarin/maccore@4cca112bc1 (#20)

macios-binaries diff: https://github.com/xamarin/macios-binaries/compare/718cef60c9c9226d54d0578126716804230db7c2..b474fa2e732974fde2edbfe054f23c5eefd0255b

Fixes xamarin/macios-binaries#20.
@rolfbjarne rolfbjarne deleted the issue-6216 branch January 12, 2021 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@spouliot spouliot spouliot approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

run-internal-tests If tests should be executed on the internal Jenkins instance.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Xcode11] [Simulator] Updating to Xcode 11 stops the simulator from launching.

5 participants

@rolfbjarne @monojenkins @xamarin-release-manager @spouliot