[security] Add new API (up to beta 6) and unit tests #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A problem, that exists with the current API, is that several constants are hidden but many are needed in some dictionaries - and not all of them can be turned into _classic_ StrongDictionary. This initial PR does not solve all the (old) problems, but it does offer some useful overloads that makes the API usable for basic usages and expose the NSDictionary-based API.
Member
|
👍 LGTM and agree on exposing the NSDictionary bits |
Contributor
|
👍 LGTM too, couldn't find even one tiny mistake and I tried hard (: |
Collaborator
|
Build success |
rolfbjarne
added a commit
to rolfbjarne/macios
that referenced
this pull request
Feb 22, 2018
This should make the "test-docs" step on wrench pass again. Commit list for xamarin/macios-binaries: * xamarin/macios-binaries@e1e8bdf Add ios/compat version of core.dll and temp.dll from d15-5 for documentation workflow. (dotnet#7) * xamarin/macios-binaries@e64e7ef Merge pull request #5 from timrisi/ClassicDocs * xamarin/macios-binaries@3c92bb1 Remove .DS_Store files * xamarin/macios-binaries@587623f Add classic docs Diff: xamarin/macios-binaries@93fb980...e1e8bdf Commit list for xamarin/maccore: * xamarin/maccore@1b5311781c [docs] Look for binary classic files in the right place. (dotnet#646) Diff: xamarin/maccore@4872731...1b53117
rolfbjarne
added a commit
that referenced
this pull request
Feb 22, 2018
) This should make the "test-docs" step on wrench pass again. Commit list for xamarin/macios-binaries: * xamarin/macios-binaries@e1e8bdf Add ios/compat version of core.dll and temp.dll from d15-5 for documentation workflow. (#7) * xamarin/macios-binaries@e64e7ef Merge pull request #5 from timrisi/ClassicDocs * xamarin/macios-binaries@3c92bb1 Remove .DS_Store files * xamarin/macios-binaries@587623f Add classic docs Diff: xamarin/macios-binaries@93fb980...e1e8bdf Commit list for xamarin/maccore: * xamarin/maccore@1b5311781c [docs] Look for binary classic files in the right place. (#646) Diff: xamarin/maccore@4872731...1b53117
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A problem, that exists with the current API, is that several constants
are hidden but many are needed in some dictionaries - and not all of
them can be turned into classic StrongDictionary.
This initial PR does not solve all the (old) problems, but it does offer
some useful overloads that makes the API usable for basic usages and
expose the NSDictionary-based API.