Bump to mono:2019-08 #6723

directhex · 2019-08-06T14:56:20Z

No description provided.

directhex · 2019-08-06T20:52:11Z

This is my first iOS rodeo, and I have no idea how to get started from here.

rolfbjarne · 2019-08-14T09:56:57Z

The build failed:

[2019-08-13T21:20:05.813Z] /Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/tools/common/StaticRegistrar.cs(554,38): error CS1061: 'TypeReference' does not contain a definition for 'ConstraintType' and no accessible extension method 'ConstraintType' accepting a first argument of type 'TypeReference' could be found (are you missing a using directive or an assembly reference?) [/Users/builder/jenkins/workspace/xamarin-macios/xamarin-macios/tools/mmp/mmp.csproj]

We're using a Mono.Cecil.dll from the mono archive, so that probably has to be updated.

directhex · 2019-08-14T13:04:08Z

Yeah, I need to update the Mono in the PR to one with the new Cecil, but I don't want to waste time doing that if I'm about to merge an important PR I need to point to

directhex · 2019-08-15T13:49:08Z

PROGRESS.

We have:

At least one HE0038 known issue on WatchOS
Undefined _mono_fconv_u8 on WatchOS
Authenticode_AsByteArray_Properties failure on WatchOS
MonoPosixHelper not present in bundle : /Users/builder/jenkins/workspace/xamarin-macios-pr-builder/tests/mmptest/regression/link-posix-2/bin/Debug/link-posix-2.app/Contents/MonoBundle/libMonoPosixHelper.dylib

akoeplinger · 2019-08-15T15:23:56Z

Regarding the mono_fconv_u8 issue that sounds like it was introduced by @filipnavara's recent PR: mono/mono#15930

Probably missing #define MONO_ARCH_EMULATE_FCONV_TO_U8 1 for mini-arm64.h

directhex · 2019-09-05T14:18:16Z

To what extent is 32-bit iOS (i.e. devices considered out of support & unserviceable by Apple as of 2 years ago) still a target?

chamons · 2019-09-05T14:19:47Z

I know the iPhone 5C is 32-bit, but isn't some of the Apple watches also 32-bit @rolfbjarne / @spouliot ?

directhex · 2019-09-05T14:27:57Z

WatchOS is a different thing to iOS isn't it?

spouliot · 2019-09-05T14:28:28Z

@directhex developers still target iOS 32 bits devices - it's fully supported on the app store (and it's even hard to remove architectures from apps until Apple removes them from the store).

directhex · 2019-09-05T14:30:11Z

Huh. TIL.

mandel-macaque · 2019-09-05T15:18:09Z

@directhex we are not to worry, I noticed that some tests are allocating TOO much memory on an iOS 32 device. I reported that to mono already and did a cherry-pick of a fix we have in master. We should be ok. This is not the first time that corefx has tests that are memory hungry and cannot be ran on a 32b devices (some File.IO tests were moving gbs from one side to another).

Mono should either fix the tests or add them to the categories that are ignored in mobile. I'm surprised that android did not run on this (unless they do not have 32b devices).

xamarin-release-manager · 2019-09-05T20:14:46Z

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥

✅ Build succeeded
✅ Packages: xamarin.ios-12.15.0.344.pkg xamarin.mac-5.15.0.344.pkg
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

3 tests failed, 168 tests passed.

Failed tests

introspection/tvOS - simulator/Debug (tvOS 9.0): Crashed
introspection/watchOS 32-bits - simulator/Debug (watchOS 2.0): Crashed
MMP Regression Tests/Mac: Failed

spouliot · 2019-09-05T21:15:48Z

Since they are now largely fixed I'll be running the submission tests with the 344 packages and mono 6.6.0.48 (as per Make.config). i'll post results here

monojenkins · 2019-09-05T21:31:12Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
🔥 Test run failed 🔥

Test results

3 tests failed, 877 tests' device not found, 167 tests passed.

Failed tests

mscorlib/iOS Unified 32-bits - simulator/Debug: Crashed
introspection/watchOS 32-bits - simulator/Debug (watchOS 2.0): Crashed
MMP Regression Tests/Mac: Failed

spouliot · 2019-09-06T12:59:37Z

Submission tests results (and emails to xamappledev) are identical to d16-3 👍

directhex · 2019-09-06T15:41:55Z

@mandel-macaque looks like that latest change caused a conflict

mandel-macaque · 2019-09-06T17:24:24Z

@directhex fixed ;)

monojenkins · 2019-09-06T17:26:56Z

Build failure
❌ Build failed or was aborted

✅ Build succeeded
✅ API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'

xamarin-release-manager · 2019-09-06T17:59:21Z

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run' 🔥 : org.jenkinsci.plugins.workflow.steps.FlowInterruptedException

✅ Build succeeded
✅ Packages: xamarin.ios-12.15.0.345.pkg xamarin.mac-5.15.0.345.pkg
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)

monojenkins · 2019-09-06T23:13:09Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
🔥 Test run failed 🔥

Test results

5 tests failed, 877 tests' device not found, 165 tests passed.

Failed tests

[NUnit] Mono SystemSecurityTests/watchOS 32-bits - simulator/Debug: Crashed
[xUnit] Mono SystemCoreXunit/watchOS 32-bits - simulator/Debug: Crashed
[xUnit] Mono SystemNetHttpUnitTestsXunit/watchOS 32-bits - simulator/Debug: Crashed
introspection/watchOS 32-bits - simulator/Debug (watchOS 2.0): Crashed
MMP Regression Tests/Mac: Failed

xamarin-release-manager · 2019-09-06T23:40:25Z

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥

✅ Build succeeded
✅ Packages: xamarin.ios-12.15.0.349.pkg xamarin.mac-5.15.0.349.pkg
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

3 tests failed, 168 tests passed.

Failed tests

mscorlib/iOS Unified 32-bits - simulator/Debug: TimedOut
introspection/watchOS 32-bits - simulator/Debug (watchOS 2.0): Crashed
MMP Regression Tests/Mac: Failed

mandel-macaque · 2019-09-07T20:02:51Z

@spouliot @directhex looking at https://jenkins.mono-project.com/job/xamarin-macios-pr-builder/11194/Test_20Report/ the 32b issues are solved. I'll investigate why the internal build gave an error.

xamarin-release-manager · 2019-09-08T00:42:37Z

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥

✅ Build succeeded
✅ Packages: xamarin.ios-12.15.0.350.pkg xamarin.mac-5.15.0.350.pkg
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

4 tests failed, 167 tests passed.

Failed tests

[NUnit] Mono Mac OS X BCL tests group 2/Mac/Full: Failed (Test run failed.)
[NUnit] Mono SystemWebServicesTests/watchOS 32-bits - simulator/Debug: Crashed
introspection/watchOS 32-bits - simulator/Debug (watchOS 2.0): Crashed
MMP Regression Tests/Mac: Failed

monojenkins · 2019-09-08T03:03:17Z

Build failure
✅ Build succeeded
✅ API Diff (from stable)
❎ Skipped API comparison because the PR has the label 'skip-api-comparison'
🔥 Test run failed 🔥

Test results

2 tests failed, 877 tests' device not found, 168 tests passed.

Failed tests

introspection/watchOS 32-bits - simulator/Debug (watchOS 2.0): Crashed
MMP Regression Tests/Mac: Failed

mandel-macaque · 2019-09-08T03:28:55Z

MMP tests are expected to fail. Rest are HE003 or a flaky test related to sockets. We are good to go.

Bump to mono:2019-08

6991793

directhex requested a review from rolfbjarne as a code owner August 6, 2019 14:56

directhex added run-all-tests Run all our tests. run-internal-tests If tests should be executed on the internal Jenkins instance. skip-api-comparison Skips API / generator diffs when testing pull requests labels Aug 6, 2019

directhex assigned rolfbjarne, spouliot and directhex Aug 6, 2019

This comment has been minimized.

Sign in to view

New Cecil API in 2019-08

e3e4597

directhex requested review from chamons and spouliot as code owners August 13, 2019 21:14

Jo Shields and others added 4 commits August 14, 2019 09:55

Permit new symbols from networkable AOT profiler in symbols test

1e6bf3b

Bump Mono to include fix for zlib linking, and new Cecil API

978b5ab

Bump packaged Mono version, to match mono.mk

b72748d

Merge branch 'master' into mono-2019-08

ffda0bd

dotnet deleted a comment from xamarin-release-manager Aug 14, 2019

dotnet deleted a comment from monojenkins Aug 14, 2019

dotnet deleted a comment from xamarin-release-manager Aug 14, 2019

dotnet deleted a comment from monojenkins Aug 14, 2019

dotnet deleted a comment from xamarin-release-manager Aug 14, 2019

We need to link against zlib now, if using libmono.a

3ebf7f5

[Tests] Ignore memory hungry tests in old devices. (#6913)

db8c49b

Ignore certain tests that use too many resources in old devices.

a691e4a

Merge branch 'master' into mono-2019-08

8b7dc53

Add missing tests that use too much memory on 32b devices.

ae9e84a

dalexsoto approved these changes Sep 7, 2019

View reviewed changes

spouliot approved these changes Sep 9, 2019

View reviewed changes

mandel-macaque merged commit 926372c into master Sep 9, 2019

steveisok mentioned this pull request Sep 24, 2019

2019-08 Mono Release mono/mono#17023

Closed

12 tasks

rolfbjarne added the not-notes-worthy Ignore for release notes label Sep 14, 2020

mandel-macaque deleted the mono-2019-08 branch December 7, 2021 20:29

Bump to mono:2019-08 #6723

Bump to mono:2019-08 #6723

Uh oh!

Conversation

directhex commented Aug 6, 2019

Uh oh!

This comment has been minimized.

directhex commented Aug 6, 2019

Uh oh!

This comment has been minimized.

rolfbjarne commented Aug 14, 2019

Uh oh!

directhex commented Aug 14, 2019

Uh oh!

directhex commented Aug 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

akoeplinger commented Aug 15, 2019

Uh oh!

directhex commented Sep 5, 2019

Uh oh!

chamons commented Sep 5, 2019

Uh oh!

directhex commented Sep 5, 2019

Uh oh!

spouliot commented Sep 5, 2019

Uh oh!

directhex commented Sep 5, 2019

Uh oh!

mandel-macaque commented Sep 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xamarin-release-manager commented Sep 5, 2019

Test results

Failed tests

Uh oh!

spouliot commented Sep 5, 2019

Uh oh!

monojenkins commented Sep 5, 2019

Test results

Failed tests

Uh oh!

spouliot commented Sep 6, 2019

Uh oh!

directhex commented Sep 6, 2019

Uh oh!

mandel-macaque commented Sep 6, 2019

Uh oh!

monojenkins commented Sep 6, 2019

Uh oh!

xamarin-release-manager commented Sep 6, 2019

Uh oh!

monojenkins commented Sep 6, 2019

Test results

Failed tests

Uh oh!

xamarin-release-manager commented Sep 6, 2019

Test results

Failed tests

Uh oh!

mandel-macaque commented Sep 7, 2019

Uh oh!

xamarin-release-manager commented Sep 8, 2019

Test results

Failed tests

Uh oh!

monojenkins commented Sep 8, 2019

Test results

Failed tests

Uh oh!

mandel-macaque commented Sep 8, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

directhex commented Aug 15, 2019 •

edited

Loading

mandel-macaque commented Sep 5, 2019 •

edited

Loading