-
Notifications
You must be signed in to change notification settings - Fork 555
Add support for Apple Development certificates to Xamarin.Mac MSBuild #6797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
build |
|
Build success |
The way to do this is to create a fork of the Xamarin.MacDev, create a pull request with your changes, and once that pull request has been merged, update this pull request with the submodule bump. |
| protected override string DeveloperRoot { get { return MacOSXSdks.Native.DeveloperRoot; } } | ||
| protected override PlatformFramework Framework { get { return PlatformFramework.MacOS; } } | ||
| protected override string PlatformName { get { return "OS X"; } } | ||
| protected override string PlatformName { get { return "macOS"; } } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not quite sure about this one but as long as our tests are happy 👍
Does mostly what the title says. I also took the opportunity to update an occurrence of "OS X" to the current branding.
Please note that I was not able to change the corresponding value for the iOS platform because those constants are in the Xamarin.MacDev submodule, and if I was make the changes in a fork, I would then have problems properly reintegrating the submodule change into this repository. I have included the required changes as a diff below; if someone could apply them for me (or tell me how I should best apply them myself), I would appreciate it. Thanks!