Skip to content

[mono] bump mono/2019-08 #7018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lewurm wants to merge 1 commit into from
Closed

[mono] bump mono/2019-08 #7018

lewurm wants to merge 1 commit into from

Conversation

@lewurm
Copy link
Contributor

@lewurm lewurm commented Sep 18, 2019

New commits in mono/mono:

Diff: https://github.com/mono/mono/compare/29b1ac19c961b959a09097dbc0fe4cd567cc5298..a0e7f9eaf2e10fb3fa9d55b8ef651256a42ebb7e

@lewurm lewurm requested a review from rolfbjarne as a code owner September 18, 2019 12:51
@lewurm
Copy link
Contributor Author

lewurm commented Sep 18, 2019

16:31:40 [0x70001195a000:] EXCEPTION handling: System.Xml.XmlException: Root element is missing.

is this a known issue?

@monojenkins
Copy link
Collaborator

monojenkins commented Sep 18, 2019

Build failure
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

2 tests failed, 156 tests passed.

Failed tests

  • [xUnit] Mono SystemXmlXunit/watchOS 32-bits - simulator/Debug: Crashed
  • MMP Regression Tests/Mac: Failed

@spouliot
Copy link
Contributor

spouliot commented Sep 19, 2019

@lewurm that's normally because there's no (xml) results available - and the real cause happened earlier (e.g. crash, timeout)

@rolfbjarne
Copy link
Member

rolfbjarne commented Sep 19, 2019

@lewurm that's normally because there's no (xml) results available - and the real cause happened earlier (e.g. crash, timeout)

It could also be that the test whose results we're trying to parse hasn't completed yet.

We run xharness.exe with --trace=E:all, which means that every exception will be printed to stdout, even if handled.

@VincentDondain VincentDondain changed the title [mono] bump mono/2018-08 [mono] bump mono/2019-08 Sep 20, 2019
@lewurm
[mono] bump mono/2018-08
e2f5acb 
New commits in mono/mono:

* mono/mono@70d69030534 [2019-08] [merp] Use a separate program as the hang supervisor. (dotnet#16900)
* mono/mono@4bff2b6370b [offsets-tool] Install clang into the user-specific python directory.
* mono/mono@81894ec8cad Implement WriteCore and ReadCore in DeflateStream
* mono/mono@bfbf823ca11 [ci] Remove more XCODE32_DIR usages (dotnet#16964)
* mono/mono@ce01b20a4d4 Add net_4.8.xml to EXTRA_DIST and bump binary-reference-assemblies again
* mono/mono@7a587d7fa61 Add .NET 4.8 reference assemblies (dotnet#16912)
* mono/mono@35e454a8f6a [sdks] Remove the mac32 build. (dotnet#16936)
* mono/mono@75eb342f532 [2019-08] [System] Make FileSystemWatcher backend non-static (dotnet#16926)
* mono/mono@5881981f790 [2019-08] [mini] Add missing membars when initializing rgctx entries (dotnet#16909)
* mono/mono@6290b6cd6e3 Temporarily disable embedded ppdb data decompression (dotnet#16911)
* mono/mono@a0e7f9eaf2e [2019-08] [arm64_32] make "Debug Mode" work on Watch series 4 with --interpreter (dotnet#16886)
* mono/mono@6275840a7f8 Rename bundle identifier for the various Mono.frameworks we create for Xamarin.iOS. Fixes dotnet#7005. (dotnet#16901)
* mono/mono@25f60932839 [corlib] Fix building nunit-lite twice (dotnet#16895)
* mono/mono@7ec17ba1be9 [2019-08] [android sdk] Add aprofutil tool (dotnet#16884)
* mono/mono@f755f3b5391 [metadata] Fix leaks when handling a few attributes (dotnet#16850)
* mono/mono@5f9a2db39b0 [2019-08] Fix infrequent hangs in test-runner. (dotnet#16854)
* mono/mono@f31f5ea1f1b [2019-08] [threads] do not convert NULL thread name (dotnet#16828)
* mono/mono@20308e6f874 [aot] Do not wrap tool_prefix path when calling strip (dotnet#16820)
* mono/mono@cecda47c489 [aprofutil] Add -p and -f options
* mono/mono@824cc12ac3f Bump to mono/corefx@e79cf5b
* mono/mono@b77dc06a7e7 [aprofutil] Install the tool correctly (dotnet#16112)
* mono/mono@1848d78d60f [aotprof-tool] Initial import of AOT profiler tool (dotnet#15384)
* mono/mono@da0086e3042 [2019-08] Add RenamedEvent* to FSW sources from CoreFX (dotnet#16756)
* mono/mono@0297b21b030 [msbuild][roslyn] Bump msbuild and roslyn to pull in new versions (dotnet#16768)
* mono/mono@40631e3b9e3 [2019-08] [aot] move method_addresses to data.rel.so section to avoid text relocations (dotnet#16751)
* mono/mono@68b77674e20 Vtable [i] can be null so this should be check before use it. Fixes dotnet#16712
* mono/mono@4a0b4f41ede [mini] publish global patches after JitInfo has been added
* mono/mono@7a1f63fde68 [debugger][android] It was not initialising seq_points on MonoCompile on Android, so when was compiling dynamic methods, seq_points wasn't created and we got the assert when try to single step.

Diff: https://github.com/mono/mono/compare/29b1ac19c961b959a09097dbc0fe4cd567cc5298..70d690305348cb30cf620db0679ba1173dc7adb0
@lewurm lewurm force-pushed the bump-mono-a0e7f9eaf2e10fb3fa9d55b8ef651256a42ebb7e branch from 3664763 to e2f5acb Compare September 20, 2019 15:41
@lewurm
Copy link
Contributor Author

lewurm commented Sep 20, 2019 •
edited
Loading

bumped again, added:

https://github.com/mono/mono/compare/29b1ac19c961b959a09097dbc0fe4cd567cc5298..70d690305348cb30cf620db0679ba1173dc7adb0

@VincentDondain
Copy link
Contributor

VincentDondain commented Sep 20, 2019

Thanks @lewurm, we're in no rush to merge this for now so I think it's good we're running tests on HEAD for now.

@monojenkins
Copy link
Collaborator

monojenkins commented Sep 20, 2019

Build failure
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

3 tests failed, 147 tests passed.

Failed tests

  • monotouch-test/watchOS 32-bits - simulator/Debug: Crashed
  • mmptest/macOS/Debug: Failed (Execution failed with exit code 7)
  • MTouch tests/NUnit: Failed (Execution failed with exit code 3)

@lewurm
Copy link
Contributor Author

lewurm commented Sep 23, 2019

good to merge?

@lewurm
Copy link
Contributor Author

lewurm commented Sep 23, 2019

Actually, not good to merge:

 Xamarin.MMP.Tests.CodeStrippingTests.ExplictStripOption_ThirdPartyLibrary_AndWarnsIfSo(True,True): lipo usage did not match expectations
Expected: True
But was: False

Xamarin.MMP.Tests.CodeStrippingTests.ShouldStripMonoPosixHelper(null,False,True): Did not contain two archs
Expected: 2
But was: 1

Xamarin.MMP.Tests.CodeStrippingTests.ShouldStripMonoPosixHelper(True,True,True): Debug lipo usage did not match expectations
Expected: True
But was: False

Xamarin.MMP.Tests.CodeStrippingTests.ShouldStripMonoPosixHelper(False,False,False): Did not contain two archs
Expected: 2
But was: 1

this is probably due to

mono/mono@35e454a [sdks] Remove the mac32 build. (#16936)

@rolfbjarne
Copy link
Member

rolfbjarne commented Sep 24, 2019

This bump was included in #7044, so this PR is now redundant.

@rolfbjarne rolfbjarne closed this Sep 24, 2019
@rolfbjarne rolfbjarne added the not-notes-worthy Ignore for release notes label Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dalexsoto dalexsoto dalexsoto approved these changes

@rolfbjarne rolfbjarne rolfbjarne approved these changes

+2 more reviewers

@spouliot spouliot spouliot approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

not-notes-worthy Ignore for release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ITMS-90806: CFBundleIdentifier collision

7 participants

@lewurm @monojenkins @spouliot @rolfbjarne @VincentDondain @dalexsoto @mandel-macaque