Bump mono to 2019-08@528103728fc2aedb7b6062e11255d39a0ed3f31c to add missing NS2.1 APIs #7147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…missing NS2.1 APIs See mono/mono#17064. The 2019-08 version of the fix adds a new assembly with NS2.1 APIs that we stubbed out in 2019-06: System.Data.DataSetExtensions.dll
akoeplinger
requested review from
VincentDondain,
chamons,
emaf,
jstedfast,
kzu,
rolfbjarne and
spouliot
as code owners
Member
Author
|
This needs to be ported to all branches that use mono 2019-08. |
mandel-macaque
approved these changes
Oct 1, 2019
Contributor
mandel-macaque
left a comment
mandel-macaque
left a comment
There was a problem hiding this comment.
@akoeplinger is this brining a new test dll that should be added to the BCL tests? if the is the case, could you create an issue and assign me?
Contributor
|
@VincentDondain please do the backport needed for this to be in all 2019-08 related branches since you are the Qbert. |
Member
Author
|
@mandel-macaque yes there should be a corresponding test dll. |
Contributor
|
@monojenkins backport to d16-4 |
dalexsoto
approved these changes
Oct 1, 2019
VincentDondain
approved these changes
Oct 1, 2019
Collaborator
|
Build failure Test results12 tests failed, 138 tests passed.Failed tests
|
rolfbjarne
approved these changes
Oct 2, 2019
Member
|
Failures are due to [FAIL] UrlProtocolTest.RegistrarTest : DidReceiveData is failing because of user agent sniffing on microsoft.com will be fixed by #7154 |
mandel-macaque
added a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Oct 7, 2019
Following PR dotnet#7147 we have a new dll and therefore new tests to run. Fixes: dotnet#7148
mandel-macaque
added a commit
that referenced
this pull request
Oct 8, 2019
monojenkins
pushed a commit
to monojenkins/xamarin-macios
that referenced
this pull request
Oct 8, 2019
Following PR dotnet#7147 we have a new dll and therefore new tests to run. Fixes: dotnet#7148
mandel-macaque
pushed a commit
that referenced
this pull request
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See mono/mono#17064.
The 2019-08 version of the fix adds a new assembly with NS2.1 APIs that we stubbed out in 2019-06: System.Data.DataSetExtensions.dll
Commit diff: mono/mono@d8441de...5281037