[TVMLKit] Add TVMLKit binding for xcode11.2b2 #7292
Conversation
spouliot
left a comment
spouliot
left a comment
There was a problem hiding this comment.
That's a breaking change, all further members gets re-numbered.
You need to file an issue with Apple and (if we're lucky) they'll fix it properly...
Otherwise we'll need to document it (and like add an [Advice])
| [ErrorDomain ("TVMLKitErrorDomain")] | ||
| public enum TVMLKitError : long { | ||
| Unknown = 1, | ||
| InvalidArguments, |
There was a problem hiding this comment.
The order of the enums matter. This changes makes InternetUnavailable to be the old one +1. Which is bad it the users do depend on the casting of enums to long/
There was a problem hiding this comment.
It's basically an ABI break.
There was a problem hiding this comment.
Not just enum to long. It breaks interop too.
|
maccore issue: https://github.com/xamarin/maccore/issues/2039 |
VincentDondain
left a comment
VincentDondain
left a comment
There was a problem hiding this comment.
Not sure why Sebastien added do-not-merge shouldn't we close this PR?
|
Build failure Test results2 tests failed, 89 tests passed.Failed tests
|
ghost
closed this
6 participants
Add TVMLKit binding for xcode11.2b2