[runtime] Clarify redirect_io behaviour #7409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `redirect_io` to be easier to re-use correctly, i.e. returning the file descriptor (instead of `0`). Comment why the file descriptor are never released. It makes sense but it's not obvious (even less in `redirect_io`) without comments. Using static fields also makes it easier for static analysis (locals are easier to process). Finally reuse, mostly, the same string for the error message, i.e. ``` $ strings runtime//.libs/mac/libxammac.x86_64.dylib | grep "Could not redirect" Xamarin.Mac: Could not redirect %s to `%s': %s ``` versus ``` $ strings runtime//.libs/mac/libxammac.x86_64.dylib | grep "Could not redirect" Xamarin.Mac: Could not redirect stdout to `%s': %s Xamarin.Mac: Could not redirect stderr to `%s': %s ```
Collaborator
|
Build failure 🔥 Build failed 🔥 |
Contributor
Author
|
build |
rolfbjarne
approved these changes
Nov 12, 2019
Collaborator
|
Build failure Test results20 tests failed, 67 tests passed.Failed tests
|
Contributor
Author
|
many, many HE0038 w/watchOS -> https://github.com/xamarin/maccore/issues/581 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
redirect_ioto be easier to re-use correctly, i.e. returning thefile descriptor (instead of
0).Comment why the file descriptor are never released. It makes sense but
it's not obvious (even less in
redirect_io) without comments.Using static fields also makes it easier for static analysis (locals are
easier to process).
Finally reuse, mostly, the same string for the error message, i.e.
versus