[CoreFoundation] CFBundle.GetAll better thread safe. #7425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial solution fixed the rance condition in which the index changed, but that did not guarantee that we would get the correct bundles. We now clone the CFArray (which also clones the callbacks set to the array) and iterate over it to make sure Apple does not do evil tings while we are iteraing. Better Fixes: https://github.com/xamarin/maccore/issues/940
spouliot
approved these changes
Nov 13, 2019
prmallic
approved these changes
Nov 13, 2019
ghost
approved these changes
Nov 13, 2019
rolfbjarne
approved these changes
Nov 13, 2019
Collaborator
|
Build failure Test results17 tests failed, 70 tests passed.Failed tests
|
Contributor
Author
|
HE0038 issues: https://github.com/xamarin/maccore/issues/581 |
Contributor
Author
|
@monojenkins backport xcode11.3 |
Contributor
Author
|
@monojenkins backport d16-5 |
Collaborator
|
@mandel-macaque backporting to xcode11.3 failed, the patch results in conflicts: Please backport manually! |
Contributor
Author
|
@monojenkins backport xcode11.2 |
Contributor
Author
|
@monojenkins backport d16-4 |
Collaborator
|
@mandel-macaque backporting to xcode11.2 failed, the patch results in conflicts: Please backport manually! |
Collaborator
|
@mandel-macaque backporting to d16-4 failed, the patch results in conflicts: Please backport manually! |
mandel-macaque
added a commit
to mandel-macaque/xamarin-macios
that referenced
this pull request
Nov 13, 2019
The initial solution fixed the rance condition in which the index changed, but that did not guarantee that we would get the correct bundles. We now clone the CFArray (which also clones the callbacks set to the array) and iterate over it to make sure Apple does not do evil tings while we are iteraing. Better Fixes: https://github.com/xamarin/maccore/issues/940
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial solution fixed the rance condition in which the index
changed, but that did not guarantee that we would get the correct
bundles. We now clone the CFArray (which also clones the callbacks set
to the array) and iterate over it to make sure Apple does not do evil
things while we are iteraing.
Better Fixes: https://github.com/xamarin/maccore/issues/940