Skip to content

[xcode11.3] Bump macios-binaries to get fix for xamarin/maccore#2068. #7512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rolfbjarne merged 2 commits into from
Dec 2, 2019
Merged

[xcode11.3] Bump macios-binaries to get fix for xamarin/maccore#2068. #7512

rolfbjarne merged 2 commits into from
Dec 2, 2019

Conversation

@monojenkins
Copy link
Collaborator

@monojenkins monojenkins commented Nov 28, 2019

@rolfbjarne rolfbjarne added pr-change-not-shipping The PR only touch files that are not shipped to customers not-notes-worthy Ignore for release notes labels Nov 28, 2019
@monojenkins
Copy link
Collaborator Author

monojenkins commented Nov 28, 2019

Build failure
❌ Build failed or was aborted

✅ Build succeeded
✅ API Diff (from stable)

@monojenkins
Copy link
Collaborator Author

monojenkins commented Nov 28, 2019

Build success
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
✅ Test run succeeded

@rolfbjarne rolfbjarne requested a review from chamons November 28, 2019 18:56
chamons
chamons approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@chamons chamons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as primarily test fix (HE0051).

@rolfbjarne rolfbjarne merged commit 2c02cf7 into dotnet:xcode11.3 Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@spouliot spouliot spouliot approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@chamons chamons chamons approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

not-notes-worthy Ignore for release notes pr-change-not-shipping The PR only touch files that are not shipped to customers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@monojenkins @spouliot @mandel-macaque @chamons @rolfbjarne