Skip to content

[runtime] Don't zero-terminate after the string buffer. Fixes #7564. #7571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rolfbjarne merged 1 commit into from
Dec 11, 2019
Merged

[runtime] Don't zero-terminate after the string buffer. Fixes #7564. #7571

rolfbjarne merged 1 commit into from
Dec 11, 2019

Conversation

@rolfbjarne
Copy link
Member

@rolfbjarne rolfbjarne commented Dec 11, 2019

Fixes #7564.

@monojenkins
Copy link
Collaborator

monojenkins commented Dec 11, 2019

Build success
✅ Build succeeded
✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
✅ Test run succeeded

@rolfbjarne rolfbjarne merged commit 3f069f4 into dotnet:master Dec 11, 2019
@rolfbjarne rolfbjarne added the bug If an issue is a bug or a pull request a bug fix label Dec 12, 2019
@rolfbjarne
Copy link
Member Author

rolfbjarne commented Dec 12, 2019

@monojenkins backport d16-5

@monojenkins monojenkins mentioned this pull request Dec 12, 2019
Merged
@rolfbjarne
Copy link
Member Author

rolfbjarne commented Dec 12, 2019

@monojenkins backport d16-4

@monojenkins monojenkins mentioned this pull request Dec 12, 2019
Closed
@mandel-macaque
Copy link
Contributor

mandel-macaque commented Dec 12, 2019

@monojenkins backport xcode11.3

@monojenkins monojenkins mentioned this pull request Dec 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@spouliot spouliot spouliot approved these changes

@mandel-macaque mandel-macaque mandel-macaque approved these changes

@chamons chamons chamons approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug If an issue is a bug or a pull request a bug fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Runtime] ARM64 trampolines crashed with the fstack-protector-strong flag enabled.

5 participants

@rolfbjarne @monojenkins @mandel-macaque @spouliot @chamons