[msbuild] Don't use events and methods that are obsolete and do nothing. #7637
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes these warnings:
IPhoneSdks.cs(22,4): warning CS0618: 'AppleSdkSettings.Changed' is obsolete: 'This event is never raised' [/work/maccore/onedotnet/xamarin-macios/msbuild/Xamarin.iOS.Tasks.Core/Xamarin.iOS.Tasks.Core.csproj]
IPhoneSdks.cs(31,4): warning CS0618: 'AppleSdkSettings.CheckChanged()' is obsolete: 'This method does nothing' [/work/maccore/onedotnet/xamarin-macios/msbuild/Xamarin.iOS.Tasks.Core/Xamarin.iOS.Tasks.Core.csproj]
MacOSXSdks.cs(18,4): warning CS0618: 'AppleSdkSettings.Changed' is obsolete: 'This event is never raised' [/work/maccore/onedotnet/xamarin-macios/msbuild/Xamarin.Mac.Tasks.Core/Xamarin.Mac.Tasks.Core.csproj]
MacOSXSdks.cs(25,4): warning CS0618: 'AppleSdkSettings.CheckChanged()' is obsolete: 'This method does nothing' [/work/maccore/onedotnet/xamarin-macios/msbuild/Xamarin.Mac.Tasks.Core/Xamarin.Mac.Tasks.Core.csproj]
Also bump Xamarin.MacDev to pick up updated Xamarin.MacDev:
* dotnet/macios-devtools@0f578f5 [tests] Upgrade to NUnit 3.12 and use package references. (dotnet#65)
* dotnet/macios-devtools@55a30e2 [tests] Adjust tests to not expect the provisioning profiles in the index in any particular order. (dotnet#63)
* dotnet/macios-devtools@dc270f6 Make methods that do nothing obsolete and fix a compiler warning. (dotnet#67)
* dotnet/macios-devtools@681aef6 Remove unused csproj. (dotnet#66)
* dotnet/macios-devtools@d78a92f Update gitignore (dotnet#55)
Diff: https://github.com/xamarin/Xamarin.MacDev/compare/ca221c8fd65a6f1d6e85d77018d4a7619a2c120d..0f578f51e63b6ff93014782dbc9378e6b6bc6d75
rolfbjarne
requested review from
VincentDondain,
chamons,
emaf,
jstedfast and
kzu
as code owners
chamons
approved these changes
Dec 20, 2019
mandel-macaque
approved these changes
Dec 20, 2019
spouliot
approved these changes
Dec 20, 2019
Collaborator
|
Build failure Test results1 tests failed, 88 tests passed.Failed tests
|
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes these warnings:
Also bump Xamarin.MacDev to pick up updated Xamarin.MacDev:
Diff: https://github.com/xamarin/Xamarin.MacDev/compare/ca221c8fd65a6f1d6e85d77018d4a7619a2c120d..0f578f51e63b6ff93014782dbc9378e6b6bc6d75