[Harness] Make sure we do not copy/generate the app sources more than once. #8243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… once. Threading is hard, even with async. We reached a situation in which the src code of the test applications from the template was being generated more thanonce. Ideally, we could have a nice solution with AsyncLazy<bool> and use the lazy async to copy the code, but it was moved to netcore 5. The fix is a little uglier but valid, lock and enure we only generate it once. Please note that you CANNOT use a lock statement inside a async method. Fixes: #8240
| return; | ||
| // mk the expected directories | ||
| if (Directory.Exists (srcOuputPath)) | ||
| Directory.Delete (srcOuputPath, true); // delete, we always want to add the embeded src |
whitneyschmidt
approved these changes
Mar 30, 2020
Collaborator
|
Build failure |
rolfbjarne
approved these changes
Mar 30, 2020
Collaborator
|
Build success |
Collaborator
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Checkout' 🔥 : hudson.AbortException: script returned exit code 128 |
Collaborator
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Checkout' 🔥 : hudson.AbortException: script returned exit code 128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Threading is hard, even with async. We reached a situation in which the
src code of the test applications from the template was being generated
more than once. Ideally, we could have a nice solution with
AsyncLazy and use the lazy async to copy the code, but it was
moved to netcore 5. The fix is a little uglier but valid, lock and
enure we only generate it once. Please note that you CANNOT use a lock
statement inside a async method.
Fixes: #8240