[Harness] Generalize the BuildProjectTask #8299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the Jenkins test tasks are very useful and do A LOT of stuff. So we try to generalize the base class, to later be able to share the most usebul ones in the shared lib.
Move the task and use composition so that we can reuse the code. This will later allow other projects to use the class without the need of Jenkins or Harness and just implement the base class.
Use compopsition to generalize the BuildProjectTask to later reuse it in the CLI.
Co-Authored-By: Rolf Bjarne Kvinge <rolf@xamarin.com>
compilation errors added by the review suggestions.
mandel-macaque
added
run-bcl-tests
Contributor
Author
|
As with others, creating a draft to simplify reviews. It is important to see the bcl tests run since they are the ones that use nuget restore. The creation of the build task is not as I wished, I'd prefer it to take testproject directly, but we are doing MSBuild.CloneProject which alters the state of the task. Later we should rethink that API so that it is more clear. |
Collaborator
|
Build failure Test results50 tests failed, 103 tests passed.Failed tests
|
rolfbjarne
approved these changes
Apr 7, 2020
Collaborator
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run' 🔥 : org.jenkinsci.plugins.workflow.steps.FlowInterruptedException ✅ Build succeeded ✅ API Diff (from stable) |
Collaborator
|
Build failure Test results1 tests failed, 152 tests passed.Failed tests
|
Collaborator
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run, Test run' 🔥 ✅ Build succeeded ✅ API Diff (from stable) Test results1 tests failed, 184 tests passed.Failed tests
|
mandel-macaque
requested review from
VincentDondain,
chamons,
emaf,
jstedfast,
kzu and
spouliot
as code owners
Collaborator
|
Build success |
Collaborator
|
Build failure Test results1 tests failed, 152 tests passed.Failed tests
|
Contributor
Author
Collaborator
|
❌ Build was (probably) aborted 🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Checkout' 🔥 : hudson.AbortException: script returned exit code 128 |
mandel-macaque
added a commit
that referenced
this pull request
Aug 5, 2020
Use composition to generalize the BuildProjectTask to later reuse it in the CLI. Co-Authored-By: Rolf Bjarne Kvinge <rolf@xamarin.com>
mandel-macaque
added a commit
that referenced
this pull request
Oct 12, 2020
Use composition to generalize the BuildProjectTask to later reuse it in the CLI. Co-Authored-By: Rolf Bjarne Kvinge <rolf@xamarin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use composition to generalize the BuildProjectTask to later reuse it in
the CLI.