[d16-7] [xtro][bindings] Add xtro support for nullability and fix some bindings #8341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 10, 2020 15:03
Enabling this will ensure that future bindings (and Xcode updates that change nullability information) are spotted right away. The binding fixes are **not** complete, i.e. what was done was mostly to debug the xtro rule and find corner cases. The backlog will be _ignored_ so the builds won't fail.
monojenkins
requested review from
VincentDondain,
chamons,
dalexsoto,
mandel-macaque,
rolfbjarne and
spouliot
as code owners
chamons
approved these changes
Apr 10, 2020
Collaborator
Author
|
Build success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling this will ensure that future bindings (and Xcode updates that
change nullability information) are spotted right away.
The binding fixes are not complete, i.e. what was done was mostly to
debug the xtro rule and find corner cases. The backlog will be
ignored so the builds won't fail.
Note: No real need to review the 2nd commit, i.e. the
.ignorefilesBackport of #8335.
/cc @spouliot