[Jenkins] Add nuint xml logs #883

mandel-macaque · 2016-09-22T19:58:25Z

Change the execution of the tests to output info in xml to be able to parsed by jenkins.

monojenkins · 2016-09-22T20:01:16Z

Build failure

rolfbjarne · 2016-09-23T05:09:54Z

tests/xharness/AppRunner.cs

 			args.Append (" -argument=-app-arg:-enablenetwork");
 			args.Append (" -setenv=NUNIT_ENABLE_NETWORK=true");
+			// detect if we are using a jenkins bot.
+			if (!string.IsNullOrEmpty (Environment.GetEnvironmentVariable ("BUILD_REVISION"))


There's already a Harness.InWrench method, so it makes sense to extract this to a Harness.InJenkins method as well.

monojenkins · 2016-09-23T07:50:11Z

Build failure

mandel-macaque · 2016-09-23T08:47:52Z

Build

mandel-macaque · 2016-09-23T15:20:27Z

@rolfbjarne I was debugging, the test were not being executed as I wanted in jenkins so I wanted to see if the message was added. Will remove if it is just garbage.

monojenkins · 2016-09-23T15:27:57Z

Build failure

rolfbjarne · 2016-09-23T15:31:20Z

Yeah, the @MonkeyWrench prefix doesn't make sense. Also it only works on wrench 😄

mandel-macaque · 2016-09-23T15:33:22Z

@rolfbjarne learning by touching ;) Lets see this next build, I have high hopes. If everything works, we should have much better comments from the bot.

monojenkins · 2016-09-26T15:03:20Z

Build failure

monojenkins · 2016-10-28T10:17:07Z

Build failure

rolfbjarne · 2016-10-28T10:18:38Z

The watchOS tests are still crashing.

monojenkins · 2016-11-07T17:49:16Z

Build failure

…parsed by the jenkins bot.

… Wrench we prefer the old style.

…that will improve the tests results reporting.

…rebuilds" (dotnet#1018)

…nly Jenkins reports.

monojenkins · 2016-11-14T16:05:15Z

Build failure

monojenkins · 2016-11-14T16:06:26Z

Build failure

monojenkins · 2016-11-14T17:13:36Z

Build failure

rolfbjarne · 2016-11-14T17:33:27Z

tests/xharness/AppRunner.cs

 			}
 		}

+		void GenerateHumanReadableLogs (string finalPath, string logHeader, XmlDocument doc){


style: Opening brace goes on the next line.

rolfbjarne · 2016-11-14T17:33:56Z

tests/xharness/AppRunner.cs

+			}
+		}
+
+		public bool TestsSucceeded (LogStream listener_log, bool timed_out, bool crashed) {


style: Opening brace goes on the next line.

rolfbjarne · 2016-11-14T17:35:47Z

tests/xharness/AppRunner.cs

-					Harness.LogWrench ("@MonkeyWrench: AddSummary: <b><i>{0} timed out</i></b><br/>", mode);
-					success = false;
-				} else if (launch_failure) {
-					Harness.LogWrench ("@MonkeyWrench: AddSummary: <b><i>{0} failed to launch</i></b><br/>", mode);


You've lost this launch_failure condition (it was added after you started your branch, and probably got removed at some when you rebased).

Good catch. Fixing.

monojenkins · 2016-11-14T22:35:18Z

Build failure

monojenkins · 2016-11-14T23:37:52Z

Build success

rolfbjarne · 2016-11-15T06:43:38Z

tests/xharness/AppRunner.cs

 				main_log.WriteLine ("Test run never launched");
 				success = false;
+			} else if (launch_failure) {
+ 					Harness.LogWrench ("@MonkeyWrench: AddSummary: <b><i>{0} failed to launch</i></b><br/>", mode);


The indentation looks wrong here.

monojenkins · 2016-11-15T12:38:43Z

Build failure

monojenkins · 2016-11-15T13:55:46Z

Build failure

monojenkins · 2016-11-15T15:27:29Z

Build failure

monojenkins · 2016-11-15T17:59:03Z

Build success

dnfclas added the cla-already-signed label Sep 22, 2016

rolfbjarne reviewed Sep 23, 2016

View reviewed changes

mandel-macaque added the do-not-merge Do not merge this pull request label Sep 23, 2016

mandel-macaque force-pushed the add-nuint-xml-logs branch 2 times, most recently from 07ce061 to 59c367d Compare September 26, 2016 14:07

mandel-macaque force-pushed the add-nuint-xml-logs branch from e26d35f to 85439c9 Compare October 25, 2016 10:51

rolfbjarne approved these changes Oct 25, 2016

View reviewed changes

spouliot removed the do-not-merge Do not merge this pull request label Oct 26, 2016

mandel-macaque force-pushed the add-nuint-xml-logs branch 3 times, most recently from 25d354a to 6554c38 Compare November 4, 2016 09:02

mandel-macaque force-pushed the add-nuint-xml-logs branch 4 times, most recently from 046e2cc to 32202b4 Compare November 7, 2016 15:41

mandel-macaque added 4 commits November 14, 2016 10:16

[Jenkins] Make test to write output as an xml file so that it can be …

fae27b4

…parsed by the jenkins bot.

Point to the correct Touvh.Unit repo.

7e0410c

Use the available property to determine if we are being ran in Jenkins.

238eb29

Log where are test results stored.

eb07a27

mandel-macaque and others added 9 commits November 14, 2016 10:16

Add @MonkeyWrench: prefix.

7b3c3d2

Ensure that we do set the build env in jenkins/run-tests.sh

c806ab9

Do not mix Wrench with Jenkins. The reports in jenkins can be Xml, in…

2d75b53

… Wrench we prefer the old style.

Ensure that the main node of the unit tests does contain the target, …

e282206

…that will improve the tests results reporting.

Revert "Fix binding project LinkWithAttributes generation to prevent …

70d89bd

…rebuilds" (dotnet#1018)

Added xslt to be used to keep the old Test Reports until we move to o…

63f0894

…nly Jenkins reports.

Add an extra log for the xslt transformation.

64d7b81

Point to the correcto dir in jenkins.

6870167

Deal with the xslt once we have finished rather than in a batch.

4dfdec7

mandel-macaque force-pushed the add-nuint-xml-logs branch from 852033b to 4dfdec7 Compare November 14, 2016 16:01

rolfbjarne requested changes Nov 14, 2016

View reviewed changes

mandel-macaque added 2 commits November 14, 2016 23:23

Remove noise.

6f1308c

Readd case removed in rebase.

96a9e4b

rolfbjarne requested changes Nov 15, 2016

View reviewed changes

Fix indentation.

0001e3a

Skip lock keychain.

20a98f9

rolfbjarne approved these changes Nov 15, 2016

View reviewed changes

mandel-macaque merged commit aa38ab6 into dotnet:master Nov 15, 2016

mandel-macaque deleted the add-nuint-xml-logs branch November 15, 2016 18:04

[Jenkins] Add nuint xml logs #883

[Jenkins] Add nuint xml logs #883

Uh oh!

Conversation

mandel-macaque commented Sep 22, 2016

Uh oh!

monojenkins commented Sep 22, 2016

Uh oh!

rolfbjarne Sep 23, 2016

Choose a reason for hiding this comment

Uh oh!

monojenkins commented Sep 23, 2016

Uh oh!

mandel-macaque commented Sep 23, 2016

Uh oh!

mandel-macaque commented Sep 23, 2016

Uh oh!

monojenkins commented Sep 23, 2016

Uh oh!

rolfbjarne commented Sep 23, 2016

Uh oh!

mandel-macaque commented Sep 23, 2016

Uh oh!

monojenkins commented Sep 26, 2016

Uh oh!

monojenkins commented Oct 28, 2016

Uh oh!

rolfbjarne commented Oct 28, 2016

Uh oh!

monojenkins commented Nov 7, 2016

Uh oh!

monojenkins commented Nov 14, 2016

Uh oh!

monojenkins commented Nov 14, 2016

Uh oh!

monojenkins commented Nov 14, 2016

Uh oh!

rolfbjarne Nov 14, 2016

Choose a reason for hiding this comment

Uh oh!

rolfbjarne Nov 14, 2016

Choose a reason for hiding this comment

Uh oh!

rolfbjarne Nov 14, 2016

Choose a reason for hiding this comment

Uh oh!

mandel-macaque Nov 14, 2016

Choose a reason for hiding this comment

Uh oh!

monojenkins commented Nov 14, 2016

Uh oh!

monojenkins commented Nov 14, 2016

Uh oh!

rolfbjarne Nov 15, 2016

Choose a reason for hiding this comment

Uh oh!

monojenkins commented Nov 15, 2016

Uh oh!

monojenkins commented Nov 15, 2016

Uh oh!

monojenkins commented Nov 15, 2016

Uh oh!

monojenkins commented Nov 15, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants